Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving the component 'verbs' ahead of 'product/project' #1202

Merged
merged 1 commit into from
Apr 25, 2019

Conversation

animeshsingh
Copy link
Contributor

@animeshsingh animeshsingh commented Apr 22, 2019

During run of pipelines, only first couple of words from comp names are displayed, and every step looks similar. So moving the verb ahead tells what each comp is doing in visual part


This change is Reviewable

@Tomcli
Copy link
Member

Tomcli commented Apr 23, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

@Tomcli: changing LGTM is restricted to assignees, and only kubeflow/pipelines repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@k8s-ci-robot
Copy link
Contributor

@Tomcli: changing LGTM is restricted to assignees, and only kubeflow/pipelines repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 23, 2019

/lgtm
@rileyjbauer Can we make component textboxes multiline (2 or 3)?

@rileyjbauer
Copy link
Contributor

@Ark-kun I created #1205 to track displaying more text

@vicaire
Copy link
Contributor

vicaire commented Apr 24, 2019

Looks like there is nothing blocking this one from getting merged.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vicaire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b70a8be into kubeflow:master Apr 25, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Feature: Add torchserve metrics

* Fix: add metrics deployment yaml

* Fix: Add data source adding steps and screenshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants