-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Python Client robust to existing IPython installations #1186
Conversation
Hi @JohnPaton. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
Hi @JohnPaton. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Co-Authored-By: JohnPaton <john@johnpaton.net>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: animeshsingh, Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: animeshsingh, Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…low#1186) * Feature: model archive and config generator for torchserve * Fix: Update readme docs for model-archiver
In the current implementation of
Client._is_ipython
, the only check performed is a simple attempted import of theIPython
package. However, this will fail in the case that the user (or container) has IPython installed, but the command is being executed from the normal Python interpreter.This PR adds an extra call to
IPython.get_ipython
, which returns an instance of the running IPython kernel if any, and otherwiseNone
. By raising anImportError
ifget_ipython
returnsNone
, the existing logic kicks in andClient._is_ipython
will returnFalse
as expected, whether IPython happens to be installed or not.This change is