fix(frontend): restrict file explorer to show only .yaml, .yml, .zip, and .tar.gz files #11623
Conversation
|
Hi @muzzlol. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
38cc2eb to
54fd789
Compare
|
A lot of validation checks for file types can now be removed from the codebase. I can make those changes, but i feel like i should get confirmation before that. sorry im kinda new to this. |
|
/ok-to-test |
|
Approvals successfully granted for pending runs. |
… and .tar.gz files Signed-off-by: muzzlol <muzxmmilkhxn@gmail.com>
54fd789 to
ba4b028
Compare
|
/ok-to-test |
|
Approvals successfully granted for pending runs. |
|
@muzzlol this looks lgtm can you update the relevant snapshot so the CI passes, I'll be happy to merge once done |
Signed-off-by: muzzlol <muzxmmilkhxn@gmail.com>
1630286 to
1a9ae9b
Compare
|
/ok-to-test |
|
Approvals successfully granted for pending runs. |
|
/approve Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
parent 7bb0c44 author chahatsagarmain <chahatsagar2003@gmail.com> 1740067717 +0530 committer chahatsagarmain <chahatsagar2003@gmail.com> 1740068190 +0530 parent 7bb0c44 author chahatsagarmain <chahatsagar2003@gmail.com> 1740067717 +0530 committer chahatsagarmain <chahatsagar2003@gmail.com> 1740068098 +0530 make commands for local testing and ci refactor Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com> chore: use local proto go packages for ci (kubeflow#11629) Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com> fix(backend): upgrade go version to 1.22.12 to fix CVE-2024-45336 (kubeflow#11631) Signed-off-by: Daniel Dowler <12484302+dandawg@users.noreply.github.com> fix(backend) fix run retry for argo (kubeflow#11585) Signed-off-by: arpechenin <arpechenin@avito.ru> fix(frontend): restrict file explorer to show only .yaml, .yml, .zip, and .tar.gz files (kubeflow#11623) * fix(frontend): restrict file explorer to show only .yaml, .yml, .zip, and .tar.gz files Signed-off-by: muzzlol <muzxmmilkhxn@gmail.com> * test(frontend): update NewPipelineVersion snapshot for file filters Signed-off-by: muzzlol <muzxmmilkhxn@gmail.com> --------- Signed-off-by: muzzlol <muzxmmilkhxn@gmail.com> fix(backend): fixes DAG status update to reflect completion of all tasks (kubeflow#11651) Signed-off-by: VaniHaripriya <vmudadla@redhat.com> chore(test): Increased timeout in test (kubeflow#11658) Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com> make commands to test locally and ci refactor Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
parent 7bb0c44 author chahatsagarmain <chahatsagar2003@gmail.com> 1740067717 +0530 committer chahatsagarmain <chahatsagar2003@gmail.com> 1740068190 +0530 parent 7bb0c44 author chahatsagarmain <chahatsagar2003@gmail.com> 1740067717 +0530 committer chahatsagarmain <chahatsagar2003@gmail.com> 1740068098 +0530 make commands for local testing and ci refactor Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com> chore: use local proto go packages for ci (kubeflow#11629) Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com> fix(backend): upgrade go version to 1.22.12 to fix CVE-2024-45336 (kubeflow#11631) Signed-off-by: Daniel Dowler <12484302+dandawg@users.noreply.github.com> fix(backend) fix run retry for argo (kubeflow#11585) Signed-off-by: arpechenin <arpechenin@avito.ru> fix(frontend): restrict file explorer to show only .yaml, .yml, .zip, and .tar.gz files (kubeflow#11623) * fix(frontend): restrict file explorer to show only .yaml, .yml, .zip, and .tar.gz files Signed-off-by: muzzlol <muzxmmilkhxn@gmail.com> * test(frontend): update NewPipelineVersion snapshot for file filters Signed-off-by: muzzlol <muzxmmilkhxn@gmail.com> --------- Signed-off-by: muzzlol <muzxmmilkhxn@gmail.com> fix(backend): fixes DAG status update to reflect completion of all tasks (kubeflow#11651) Signed-off-by: VaniHaripriya <vmudadla@redhat.com> chore(test): Increased timeout in test (kubeflow#11658) Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com> make commands to test locally and ci refactor Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com> add missing step Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
Description of your changes:
Restricted the file explorer to only show .yaml, .yml, .zip, and .tar.gz files instead of all files when selecting pipeline files to improve user experience.
Checklist: