component readmes #1147
component readmes #1147
Conversation
|
/assign @Ark-kun |
| ```python | ||
| # Additional Parameters | ||
| EXPERIMENT_NAME = 'Seldon Core - Serve PyTorch Model' | ||
| COMPONENT_SPEC_URI = 'https://raw.githubusercontent.com/kubeflow/pipelines/master/components/ibm-components/ffdl/serve/component.yaml' |
There was a problem hiding this comment.
Nit: It's probably better to inline this variable into the load_component_from_url call.
Otherwise, with multiple components, it's harder to copy-paste the load_component lines since the variables have the same name.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Component READMEs for IBM OSS components
This change is