feat(api): Add SemaphoreKey and MutexName fields to proto #11384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ddalvi <ddalvi@redhat.com>
2 tasks
2 tasks
|
/lgtm |
|
/lgtm |
|
/ok-to-test |
|
Approvals successfully granted for pending runs. |
|
lgtm but waiting for #11370 /hold |
|
/unhold |
|
/lgtm |
|
/approve |
|
@chensun can you ack this api format? we would like to move forward with this approach, does the spec/terminology work for you? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun, gregsheremeta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mholder6
pushed a commit
to mholder6/pipelines
that referenced
this pull request
Jan 31, 2025
Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com> docs(backend): improved backend README (kubeflow#11511) * improved backend README Signed-off-by: Daniel Dowler <12484302+dandawg@users.noreply.github.com> * Update backend/README.md Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com> Signed-off-by: Daniel Dowler <12484302+dandawg@users.noreply.github.com> * Update backend/README.md Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com> Signed-off-by: Daniel Dowler <12484302+dandawg@users.noreply.github.com> * Update backend/README.md Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com> Signed-off-by: Daniel Dowler <12484302+dandawg@users.noreply.github.com> * Update backend/README.md Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com> Signed-off-by: Daniel Dowler <12484302+dandawg@users.noreply.github.com> --------- Signed-off-by: Daniel Dowler <12484302+dandawg@users.noreply.github.com> Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com> fix(CI): Use the correct image registry for replacements in integration tests (kubeflow#11564) * Use the correct image registry for replacements in integration tests The image registry was changed to GitHub Container Registry in the 2.4 release. Signed-off-by: mprahl <mprahl@users.noreply.github.com> * Print the pod logs when the pods fail to start in integration tests Signed-off-by: mprahl <mprahl@users.noreply.github.com> * Fix the sample compilation in the API server container build Signed-off-by: mprahl <mprahl@users.noreply.github.com> * Show the output when building the container images in CI Signed-off-by: mprahl <mprahl@users.noreply.github.com> --------- Signed-off-by: mprahl <mprahl@users.noreply.github.com> feat(api): Add SemaphoreKey and MutexName fields to proto (kubeflow#11384) Signed-off-by: ddalvi <ddalvi@redhat.com>
mholder6
pushed a commit
to mholder6/pipelines
that referenced
this pull request
Jan 31, 2025
Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com> docs(backend): improved backend README (kubeflow#11511) * improved backend README Signed-off-by: Daniel Dowler <12484302+dandawg@users.noreply.github.com> * Update backend/README.md Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com> Signed-off-by: Daniel Dowler <12484302+dandawg@users.noreply.github.com> * Update backend/README.md Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com> Signed-off-by: Daniel Dowler <12484302+dandawg@users.noreply.github.com> * Update backend/README.md Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com> Signed-off-by: Daniel Dowler <12484302+dandawg@users.noreply.github.com> * Update backend/README.md Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com> Signed-off-by: Daniel Dowler <12484302+dandawg@users.noreply.github.com> --------- Signed-off-by: Daniel Dowler <12484302+dandawg@users.noreply.github.com> Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com> fix(CI): Use the correct image registry for replacements in integration tests (kubeflow#11564) * Use the correct image registry for replacements in integration tests The image registry was changed to GitHub Container Registry in the 2.4 release. Signed-off-by: mprahl <mprahl@users.noreply.github.com> * Print the pod logs when the pods fail to start in integration tests Signed-off-by: mprahl <mprahl@users.noreply.github.com> * Fix the sample compilation in the API server container build Signed-off-by: mprahl <mprahl@users.noreply.github.com> * Show the output when building the container images in CI Signed-off-by: mprahl <mprahl@users.noreply.github.com> --------- Signed-off-by: mprahl <mprahl@users.noreply.github.com> feat(api): Add SemaphoreKey and MutexName fields to proto (kubeflow#11384) Signed-off-by: ddalvi <ddalvi@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
This PR introduces
semaphoreKeyandmutexNamefields inPipelineConfigproto to support pipeline-level concurrency controls in KFP.Pre-requisite to #11340
Checklist: