Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adding HumairAK to root OWNERS #11253

Merged
merged 1 commit into from
Sep 27, 2024
Merged

chore: adding HumairAK to root OWNERS #11253

merged 1 commit into from
Sep 27, 2024

Conversation

chensun
Copy link
Member

@chensun chensun commented Sep 26, 2024

Description of your changes:

Checklist:

@chensun
chore: adding HumairAK to root OWNERS
82126d1 
Signed-off-by: Chen Sun <chensun@users.noreply.github.com>
gmfrasca
gmfrasca reviewed Sep 27, 2024
View reviewed changes
Copy link
Member

@gmfrasca gmfrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Sep 27, 2024
@franciscojavierarceo
Copy link

franciscojavierarceo commented Sep 27, 2024 •
edited
Loading

/lgtm

1 similar comment
@rimolive
Copy link
Member

/lgtm

@anishasthana
Copy link
Contributor

/lgtm

hbelmiro
hbelmiro reviewed Sep 27, 2024
View reviewed changes
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

DharmitD
DharmitD reviewed Sep 27, 2024
View reviewed changes
Copy link
Contributor

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@droctothorpe
Copy link
Contributor

/lgtm

This is fantastic. Thank you all!

@chensun
Copy link
Member Author

chensun commented Sep 27, 2024

/approve

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit feacb52 into master Sep 27, 2024
6 checks passed
@google-oss-prow google-oss-prow bot deleted the chensun-patch-7 branch September 27, 2024 15:48
VaniHaripriya pushed a commit to VaniHaripriya/data-science-pipelines that referenced this pull request Oct 1, 2024
@chensun @VaniHaripriya
chore: adding HumairAK to root OWNERS (kubeflow#11253)
d9ba586 
Signed-off-by: Chen Sun <chensun@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbelmiro hbelmiro hbelmiro left review comments

@gmfrasca gmfrasca gmfrasca left review comments

@DharmitD DharmitD DharmitD left review comments

@ouadakarim ouadakarim Awaiting requested review from ouadakarim

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@rimolive rimolive

@anishasthana anishasthana

@HumairAK HumairAK

@hbelmiro hbelmiro

@droctothorpe droctothorpe

@gmfrasca gmfrasca

@DharmitD DharmitD

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@chensun @franciscojavierarceo @rimolive @anishasthana @droctothorpe @hbelmiro @gmfrasca @DharmitD @HumairAK