Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Simplified the @pipeline decorator #1120

Merged

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Apr 9, 2019

Moved metadata-related code to _metadata.
Pipeline.get_pipeline_functions now returns the list of pipeline functions.
Now the pipeline name, description and other metadata is passed directly with the pipeline instead of a using global variables.

(The global pipeline list is still used by the command-line compiler.)


This change is Reviewable

Moved metadata-related code to _metadata.
`Pipeline.get_pipeline_functions` now returns the list of pipeline functions.
@Ark-kun Ark-kun force-pushed the SDK---Simplified-the-@pipeline-decorator branch from 87722dc to abd5e7e Compare April 9, 2019 20:28
@gaoning777
Copy link
Contributor

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 12, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 12, 2019

/test kubeflow-pipeline-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit c67aea7 into kubeflow:master Apr 12, 2019
@Ark-kun Ark-kun deleted the SDK---Simplified-the-@pipeline-decorator branch April 15, 2019 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants