-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backend): implement subdag output resolution #11196
Changes from 17 commits
b1da706
4c5d97e
5235a84
1cefad2
87914ca
e3baa89
2958960
7c66a33
dd65ce1
d15884a
93d1f3c
b8efd3c
78beb55
0076a2d
9127cc1
9d9b578
704d349
4d14cfe
17e0c5d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -148,6 +148,17 @@ func (l *LauncherV2) Execute(ctx context.Context) (err error) { | |
} | ||
} | ||
glog.Infof("publish success.") | ||
// At the end of the current task, we check the statuses of all tasks in the current DAG and update the DAG's status accordingly. | ||
// TODO: If there's a pipeline whose only components are DAGs, this launcher logic will never run and as a result the dag status will never be updated. We need to implement a mechanism to handle this edge case. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I can't imagine a valid case for this. and I vaguely recall the compiler check that a pipeline must have concrete tasks. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If that's the case then I'll reword it, as the screenshots of the |
||
dag, err := l.metadataClient.GetDAG(ctx, execution.GetExecution().CustomProperties["parent_dag_id"].GetIntValue()) | ||
if err != nil { | ||
glog.Errorf("DAG Status Update: failed to get DAG: %s", err.Error()) | ||
} | ||
pipeline, _ := l.metadataClient.GetPipelineFromExecution(ctx, execution.GetID()) | ||
err = l.metadataClient.UpdateDAGExecutionsState(ctx, dag, pipeline) | ||
if err != nil { | ||
glog.Errorf("failed to update DAG state: %s", err.Error()) | ||
} | ||
}() | ||
executedStartedTime := time.Now().Unix() | ||
execution, err = l.prePublish(ctx) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove?