Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fixed e2e tests #11072

Merged
merged 1 commit into from
Aug 5, 2024
Merged

chore: Fixed e2e tests #11072

merged 1 commit into from
Aug 5, 2024

Conversation

hbelmiro
Copy link
Contributor

@hbelmiro hbelmiro commented Aug 5, 2024

Fixes: #11069

Tests were failing due to lack of disk space. This PR changes the workflow so each test suite runs on its own runner.

Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
@hbelmiro hbelmiro changed the title Test e2e Fixes e2e tests Aug 5, 2024
@hbelmiro hbelmiro changed the title Fixes e2e tests bug: Fixes e2e tests Aug 5, 2024
@hbelmiro hbelmiro changed the title bug: Fixes e2e tests chore: Fixed e2e tests Aug 5, 2024
@hbelmiro hbelmiro marked this pull request as ready for review August 5, 2024 19:00
@google-oss-prow google-oss-prow bot requested a review from zijianjoy August 5, 2024 19:00
@hbelmiro
Copy link
Contributor Author

hbelmiro commented Aug 5, 2024

@DharmitD can you PTAL?

Copy link
Contributor

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed GHA runs for each test suite within e2e tests, all running successfully

/lgtm

Copy link
Contributor

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/Approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DharmitD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 6c4a250 into kubeflow:master Aug 5, 2024
8 checks passed
@hbelmiro hbelmiro deleted the fix-e2e branch August 5, 2024 19:30
@gregsheremeta
Copy link
Contributor

nice work!

droctothorpe pushed a commit to droctothorpe/pipelines that referenced this pull request Aug 13, 2024
Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
R3hankhan123 pushed a commit to R3hankhan123/pipelines that referenced this pull request Sep 20, 2024
Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e tests are failing
3 participants