-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix CI failure for periodic functional tests #10817
test: fix CI failure for periodic functional tests #10817
Conversation
Hi @tmvfb. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Igor Kvachenok <igor.kvachenok@prokube.ai>
99d4bb9
to
5e68845
Compare
/ok-to-test |
@tmvfb: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
cc: @chensun
@chensun could you please review and approve? Thanks. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tmvfb this still seems to be failing: https://github.com/kubeflow/pipelines/actions/runs/9197318968 |
Yep, you are right, I already started looking into it, think I solved this particular issue here #10837. Other problems are still very probable, but unfortunately I don't have a functional gcloud cluster to test on my fork/locally, so it seems it's going to be one step at a time. |
Description of your changes:
GitHub CI periodic functional tests proposed in #10751 currently fail due to insufficient permissions:
This PR modifies test file to be compatible with GitHub actions.
Checklist: