fix(frontend): reduce list run latency #10797
Conversation
|
Here's some before and after screenshots for reference. Before the change (note the many duplicate experiment/id requests at the bottom of the waterfall): After the change (just one request for all experiments): |
709e88b to
f689eba
Compare
|
Will improve the error handling tomorrow. |
|
@droctothorpe: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Error handling improved. All unit tests updated and passing. |
|
tested and has the desired affect:
/lgtm |
|
Thanks, @HumairAK! /assign @jlyaoyuli |
|
cc @chensun |
|
/lgtm |
|
I think we found a bug. Please do not merge yet. Will update soon. |
Signed-off-by: droctothorpe <mythicalsunlight@gmail.com> Co-authored-by: quinnovator <jack@jq.codes> Co-authored-by: tarat44 <32471142+tarat44@users.noreply.github.com> Co-authored-by: owmasch <owenmaschal0598@gmail.com>
|
Fixed the issue. It wasn't handling multi-user deployments properly. |
|
@droctothorpe Please sign-off your commits |
Signed-off-by: droctothorpe <mythicalsunlight@gmail.com>
Done! 👍 |
|
/retest-required |
|
/test kubeflow-pipeline-frontend-test |
|
The performance improvement is especially noticeable when you select 100 rows in the dropdown in the bottom right hand corner. It takes the same amount of time to load 100 rows as it does to load 10. |
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun, HumairAK, rimolive The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
these tests can be flaky, retrying /test kubeflow-pipeline-frontend-test |
|
@droctothorpe: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test kubeflow-pipeline-frontend-test |
|
nice, thanks @droctothorpe ! |
|
Thanks for shepherding it through, @HumairAK! Much appreciated. 🙏 |
Description of your changes:
This PR updates the list runs page to reduce the number of API calls to the experiments API by retrieving all experiments with one request instead of making a discrete request for each run. It also includes a similar update for the list recurring runs page.
The relevant unit tests have been updated accordingly.
Additional information available in this issue: #10778.
Shout out to @quinnovator and @tarat44 for collaborating on it.
Checklist: