Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GH workflow): migrate periodic functional tests to GH actions #10751

Merged
merged 6 commits into from
May 9, 2024
Merged

feat(GH workflow): migrate periodic functional tests to GH actions #10751

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cdfc9e5
periodic functional tests migration
shruti2522 Apr 25, 2024
59de798
updated kind installation and artifact collection
shruti2522 Apr 25, 2024
2e5db78
updated artifact collection code
shruti2522 Apr 26, 2024
f923dea
updated version
shruti2522 May 4, 2024
2c37d1f
updated path
shruti2522 May 4, 2024
d01c26b
added log_dir
shruti2522 May 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/periodic.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,10 @@ jobs:
node_image: kindest/node:v1.29.2
- name: Run Functional Tests
run: |
log_dir=$(mktemp -d)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add this line back and don't make any other changes. All we need is this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, might have done it by mistake. I will add it back

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

./test/kfp-functional-test/kfp-functional-test.sh > $log_dir/periodic_tests.txt
- name: Collect test results
if: always()
uses: actions/upload-artifact@v4
with:
name: periodic-functional-artifacts
path: $log_dir
path: /tmp/tmp.*/*