Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add licenses for katib-launcher #1056

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Conversation

hougangliu
Copy link
Member

@hougangliu hougangliu commented Mar 28, 2019

This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 28, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4b56e7b into kubeflow:master Mar 28, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Add travis ci

* Download kubebuilder

* Fix mv dir

* Add go coverage

* Create go.yml

* Use github action for unit test

* Move unit test to github action

* Remove kubebuilder dep for manifests gen

* Add retry on update
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
…ng key. (kubeflow#1056)

* fix(pipelineloop): caching should include the params for makeing caching key.

* Get params from run spec itself.

* Migrated cache for custom task controllers to gorm v2.

* code cleanup.

* Added retry for cache connect until timoeut.

* improved tests to be able to detect config maps. Better error reporting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants