-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backend + SDK): Add Backend and SDK support for timeout in pod spec #10481
Conversation
fyi @roytman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm for SDKs
/assign @chensun for backend changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com>
46dc14f
to
8452755
Compare
Squashed and signed the commit for the new DCO check. |
/lgtm for SDK |
Will rebase this after #10496 since that PR will also cause a conflict after merge. |
Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com>
@Tomcli: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks @chensun |
…pec (kubeflow#10481) * Add backend and sdk support for pod spec timeout Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com> * fix conflicts Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com> --------- Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com>
…pec (kubeflow#10481) * Add backend and sdk support for pod spec timeout Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com> * fix conflicts Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com> --------- Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com>
…pec (kubeflow#10481) * Add backend and sdk support for pod spec timeout Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com> * fix conflicts Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com> --------- Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com>
…pec (kubeflow#10481) * Add backend and sdk support for pod spec timeout Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com> * fix conflicts Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com> --------- Signed-off-by: Tommy Li <Tommy.chaoping.li@ibm.com>
Description of your changes:
fixes #9996
Add Backend and SDK support for pod timeout (using pod spec activeDeadlineSeconds). This is the same approach defined in the Argo timeout feature.
The SDK definition of pod timeout is similar to KFP V1:
pipelines/sdk/python/kfp/deprecated/dsl/_pipeline.py
Lines 109 to 116 in 3f0fc06
Checklist: