Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a missing precheck in create cluster component #1028

Merged
merged 1 commit into from
Mar 23, 2019
Merged

Fix a missing precheck in create cluster component #1028

merged 1 commit into from
Mar 23, 2019

Conversation

hongye-sun
Copy link
Contributor

@hongye-sun hongye-sun commented Mar 23, 2019 •
edited by jlewi
Loading

This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 23, 2019

/lgtm

What happens if you just skip those empty properties?

@hongye-sun
Copy link
Contributor Author

There is subsequent code that requires the property is set and there is no difference to set it as an empty object.

@hongye-sun
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3b949b3 into kubeflow:master Mar 23, 2019
hongye-sun added a commit to hongye-sun/pipelines that referenced this pull request Mar 25, 2019
@hongye-sun
Release components to include fix kubeflow#1028.
74d6d08
k8s-ci-robot pushed a commit that referenced this pull request Mar 25, 2019
@hongye-sun @k8s-ci-robot
Release components to include fix #1028. (#1032)
d2f5cc9
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@Minkyu-Choi
Add S3 access key format for prior version of KFServing (kubeflow#1028)
78d231e
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@Tomcli
sdk(feat): add metadata support for loop (kubeflow#1028)
71f1cc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

@gaoning777 gaoning777 Awaiting requested review from gaoning777

Assignees

@Ark-kun Ark-kun

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hongye-sun @Ark-kun @k8s-ci-robot