Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade ks in deployer to fix one block issue #1005

Merged
merged 1 commit into from
Mar 27, 2019
Merged

upgrade ks in deployer to fix one block issue #1005

merged 1 commit into from
Mar 27, 2019

Conversation

jinchihe
Copy link
Member

@jinchihe jinchihe commented Mar 20, 2019 •
edited by jlewi
Loading

fixes: #241

This change is Reviewable

@jinchihe
Copy link
Member Author

/assign @Ark-kun

@hongye-sun
Copy link
Contributor

/lgtm

@Ark-kun Ark-kun assigned IronPan and unassigned Ark-kun Mar 20, 2019
@jinchihe
Copy link
Member Author

@IronPan Could you please take a look and approve if no more problems? Thanks.

@jinchihe jinchihe mentioned this pull request Mar 27, 2019
Closed
@vicaire
Copy link
Contributor

vicaire commented Mar 27, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vicaire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vicaire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4029513 into kubeflow:master Mar 27, 2019
@jinchihe jinchihe deleted the upgrade_ks_in_deployer branch March 27, 2019 05:22
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@Tomcli
Remove old build dependencies (kubeflow#1005)
8d694c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoning777 gaoning777 Awaiting requested review from gaoning777

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

Assignees

@IronPan IronPan

@vicaire vicaire

@hongye-sun hongye-sun

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Our ksonnet sometimes throws "SIGSEGV: segmentation violation" failing deployment
6 participants
@jinchihe @hongye-sun @vicaire @k8s-ci-robot @Ark-kun @IronPan