Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deplize #10

Merged
merged 1 commit into from
Jun 7, 2018
Merged

deplize #10

merged 1 commit into from
Jun 7, 2018

Conversation

ynqa
Copy link
Contributor

@ynqa ynqa commented Jun 6, 2018 •
edited by jlewi
Loading

Enable to install the dependencies of pipelines by dep ensure

This change is Reviewable

@k8s-ci-robot k8s-ci-robot requested review from jlewi and vicaire June 6, 2018 04:06
@k8s-ci-robot
Copy link
Contributor

Hi @ynqa. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ynqa
Copy link
Contributor Author

ynqa commented Jun 6, 2018

/assign @vicaire

@vicaire
Copy link
Contributor

vicaire commented Jun 6, 2018

/lgtm cancel

@vicaire
Copy link
Contributor

vicaire commented Jun 6, 2018

/approve cancel

@vicaire
Copy link
Contributor

vicaire commented Jun 6, 2018

/lgtm

@vicaire
Copy link
Contributor

vicaire commented Jun 6, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vicaire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlewi
Copy link
Contributor

jlewi commented Jun 7, 2018

/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot merged commit 9cd9c7b into kubeflow:master Jun 7, 2018
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@yuzisun @k8s-ci-robot
Update dep with Knative dependency and add knative service placeholder (
4b72042 
kubeflow#10)

* update dep dependency for knative

* watch knative service and generate rbac
HumairAK referenced this pull request in HumairAK/data-science-pipelines Jan 25, 2024
@openshift-merge-bot
Merge pull request #10 from HumairAK/model_name
763dd96 
UPSTREAM: <carry>: correct typo in experiment model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlewi jlewi Awaiting requested review from jlewi

@vicaire vicaire Awaiting requested review from vicaire

Assignees

@jlewi jlewi

@vicaire vicaire

Labels
approved lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ynqa @k8s-ci-robot @vicaire @jlewi