Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist pod logs after they finish #93

Closed
yebrahim opened this issue Nov 6, 2018 · 4 comments
Closed

Persist pod logs after they finish #93

yebrahim opened this issue Nov 6, 2018 · 4 comments
Labels
area/frontend area/persist-agent

Comments

@yebrahim
Copy link
Contributor

yebrahim commented Nov 6, 2018

This is needed so that pods can be garbage collected after they've finished, and to remove the dependency on the cluster state.

Currently, we're already seeing issues when a cluster is resized where the frontend can't find pods started by some of the runs.
@IronPan
Copy link
Member

IronPan commented Dec 6, 2018

close #439?

@rileyjbauer rileyjbauer mentioned this issue Dec 14, 2018
Closed
@yebrahim
Copy link
Contributor Author

yebrahim commented Jan 3, 2019

Seems like Argo has an option to archive logs after the pod is done.

@gaoning777 @Ark-kun can you guys take a look to see if this is easy to add in the compiler?

@IronPan
Copy link
Member

IronPan commented Jan 4, 2019 •
edited
Loading

It looks like a simple flag in the template spec
https://github.com/argoproj/argo/blob/afdac9bb34fe8a01ad511323a00ccf6c07e41137/pkg/apis/workflow/v1alpha1/types.go#L307

And given the comment here, it will be overridden by the output artifact spec, which already exist
https://github.com/argoproj/argo/blob/afdac9bb34fe8a01ad511323a00ccf6c07e41137/pkg/apis/workflow/v1alpha1/types.go#L188

@IronPan IronPan mentioned this issue Mar 1, 2019
Closed
@vicaire
Copy link
Contributor

vicaire commented Mar 26, 2019

Resolving in favor of #844

@vicaire vicaire closed this as completed Mar 26, 2019
@jingzhang36 jingzhang36 mentioned this issue Jan 21, 2020
Closed
Linchin pushed a commit to Linchin/pipelines that referenced this issue Apr 11, 2023
@jlewi @k8s-ci-robot
Fix the ingress component for Argo. (kubeflow#93)
3991cf2 
* Annotations need to be in metadata; this was preventing the static ip
  from being properly assigned.

* Delete the prow env since we no longer use it.

* Recreate the kubeflow-ci environment since the ip address changed.

* Fix kubeflow#92
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
@ellistarn @k8s-ci-robot
Adds Animesh as an Approver (kubeflow#93)
ed4c7b7
HumairAK referenced this issue in red-hat-data-services/data-science-pipelines Mar 11, 2024
@Tomcli
Add volumeop and volumesnapshot support (#93)
a47ae08 
* add volumeop support workaround

* add volumesnapshot workaround

* update resourceop integration

* add sorting to avoid randomness

* fix bug

* update sample

* minor code cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/frontend area/persist-agent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yebrahim @IronPan @vicaire