Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis uses the .travis.yml config from the branch, but tests code from a merge #929

Closed
Ark-kun opened this issue Mar 6, 2019 · 2 comments

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 6, 2019

https://travis-ci.com/kubeflow/pipelines/jobs/182659416
Travis checks out the code correctly:

git clone --depth=50 https://github.com/kubeflow/pipelines.git kubeflow/pipelines
cd kubeflow/pipelines/
git fetch origin +refs/pull/919/merge:1 #Checking out the result of merging PR to master
git checkout -qf FETCH_HEAD

But Travis caches the build configuration (.travis.yml) before the build. If some job fails, and the master is updated, the subsequent runs will use the old build configuration, even though the master have a new one.
So, when someone makes a breaking change that includes a change to the .travis.yml, other PRs may start failing the tests.

@vicaire
Copy link
Contributor

vicaire commented Mar 26, 2019

Can this be closed?

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Sep 3, 2019

This is an external (Travis) issue.

@Ark-kun Ark-kun closed this as completed Sep 3, 2019
Linchin pushed a commit to Linchin/pipelines that referenced this issue Apr 11, 2023
Add tf-operator postsubmit test
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this issue Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants