Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline name is not checked #825

Closed
Dylan-Rich opened this issue Feb 13, 2019 · 2 comments
Closed

Pipeline name is not checked #825

Dylan-Rich opened this issue Feb 13, 2019 · 2 comments
Assignees
@Ark-kun
Labels
area/sdk/dsl/compiler

Comments

@Dylan-Rich
Copy link

If you use empty string as the pipeline name, the resulting workflow is invalid (empty template name).
@rileyjbauer
Copy link
Contributor

Hello! What interface were you using when you encountered this issue: web UI, notebook, CLI?

@rileyjbauer rileyjbauer self-assigned this Feb 14, 2019
@Ark-kun Ark-kun assigned Ark-kun and unassigned rileyjbauer Mar 15, 2019
@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 15, 2019

This is caused by lack of validation in the DSL compiler. I'm on it.

Ark-kun added a commit to Ark-kun/pipelines that referenced this issue Mar 20, 2019
@Ark-kun
SDK/DSL/Compileer - Fixed handling of empty pipeline name
ed8c19d 
Fixes kubeflow#825
@Ark-kun Ark-kun mentioned this issue Mar 20, 2019
Merged
k8s-ci-robot pushed a commit that referenced this issue Mar 21, 2019
@Ark-kun @k8s-ci-robot
SDK/DSL/Compileer - Fixed handling of empty pipeline name (#1009)
fac06e9 
Fixes #825
Linchin pushed a commit to Linchin/pipelines that referenced this issue Apr 11, 2023
@Bobgy
test(gcp): refactor standar cluster package with instance and upstrea…
66b43c5 
…m, adjust node locations (kubeflow#825)

* refactor

* refactor step 2

* update nodepool locations

* update
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this issue Mar 11, 2024
@Tomcli
Enable pipelineparam for container env (kubeflow#825)
1f75071
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ark-kun Ark-kun

Labels
area/sdk/dsl/compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Ark-kun @Dylan-Rich @rileyjbauer