Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sdk] v2compat - consistent naming of pipeline root parameter #6307

Closed
Bobgy opened this issue Aug 12, 2021 · 2 comments · Fixed by #6329
Closed

[sdk] v2compat - consistent naming of pipeline root parameter #6307

Bobgy opened this issue Aug 12, 2021 · 2 comments · Fixed by #6329
Assignees
@chensun

Comments

@Bobgy
Copy link
Contributor

Bobgy commented Aug 12, 2021

pipeline root parameter is called pipeline-output-directory in KFP UI/SDK
can we rename it to pipeline-root to be consistent with SDK API?

Originally posted by @Bobgy in #5779 (comment)
@Bobgy
Copy link
Contributor Author

Bobgy commented Aug 12, 2021

/assign @chensun

@Bobgy Bobgy mentioned this issue Aug 12, 2021
Closed
23 tasks
@zijianjoy
Copy link
Collaborator

I agree with the consistency on naming it pipeline-root. Also TFX is using the term pipeline-root: https://www.tensorflow.org/tfx/guide/build_tfx_pipeline#using_the_pipeline_class.

@chensun chensun mentioned this issue Aug 13, 2021
Merged
1 task
google-oss-robot pushed a commit that referenced this issue Aug 13, 2021
@chensun
feat(backend/sdk): Rename pipeline-output-directory to `pipeline-ro…
7559e27 
…ot`. Fixes #6307 (#6329)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chensun chensun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(backend/sdk): Rename pipeline-output-directory to pipeline-root. Fixes #6307 chensun/pipelines
3 participants
@chensun @Bobgy @zijianjoy