[bug] GCP marketplace default config values do not work

[Bobgy]

What steps did you take

1. Install KFP from AI Platform Pipelines
2. check managed storage
3. fill in db connection name and gcs bucket name
4. leave the rest as empty

What happened:

All the default values are filled by empty strings.

What did you expect to happen:

I was expecting default values in values.yaml are set, e.g.

pipelines/manifests/gcp_marketplace/chart/kubeflow-pipelines/values.yaml

Line 27 in a1ecb3d

databaseNamePrefix: '{{ .Release.Name | replace "-" "_" | replace "." "_" }}'

.

However, I verified that cache configmap in fact has db name as _cache without the prefix.

Labels

/area deployment

---

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

[google-oss-robot]

@Bobgy: The label(s) area/deployment cannot be applied, because the repository doesn't have them.

In response to this:

What steps did you take

1. Install KFP from AI Platform Pipelines
2. check managed storage
3. fill in db connection name and gcs bucket name
4. leave the rest as empty

What happened:

All the default values are filled by empty strings.

What did you expect to happen:

I was expecting default values in values.yaml are set, e.g.

pipelines/manifests/gcp_marketplace/chart/kubeflow-pipelines/values.yaml

Line 27 in a1ecb3d

databaseNamePrefix: '{{ .Release.Name | replace "-" "_" | replace "." "_" }}'

.

Labels

/area deployment

---

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Bobgy]

We should define default values in schema.yaml, see https://github.com/GoogleCloudPlatform/marketplace-k8s-app-tools/blob/master/docs/schema.md#helm-chart-values

[Bobgy]

Cases we need to test after the release:

• when deploying with managed storage, leave db username as empty, and verify it defaults to "root".
• similarly leave databasePrefixName as empty, verify dbs are created as _cache, _pipeline etc.

[Bobgy]

Reopen to wait for verification

[Bobgy]

Now the database username defaults to "root" on the UI.