Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameterize kaniko pod namespace #344

Closed
IronPan opened this issue Nov 21, 2018 · 1 comment
Closed

Parameterize kaniko pod namespace #344

IronPan opened this issue Nov 21, 2018 · 1 comment
Assignees
@gaoning777
Labels
area/sdk/dsl/compiler

Comments

@IronPan
Copy link
Member

IronPan commented Nov 21, 2018

The kaniko pod is hardcoded to kubeflow namespace. We should make this configurable so that it still work if people deploy kubeflow to a different ns.

https://github.com/kubeflow/pipelines/blob/master/sdk/python/kfp/compiler/_component_builder.py#L247
@gaoning777
Copy link
Contributor

This is actually already parameterized through the build_python_component function when authors build components.

@gaoning777 gaoning777 self-assigned this Nov 21, 2018
@snyk-bot snyk-bot mentioned this issue May 26, 2021
Open
Linchin pushed a commit to Linchin/pipelines that referenced this issue Apr 11, 2023
@jlewi @k8s-ci-robot
Update auto-deploy infrastructure to use the new kfctl binary. (kubef…
6872f51 
…low#344)

* Update auto-deploy infrastructure to use the new kfctl binary.

* Move auto-deployments into project kubeflow-ci-deployment.

* Fix a bug in cleanup_ci.py; we were not properly handling the case where there was no manifest in the deployment.

* Update cleanup ci cron jobs to run in two projects
  kubeflow-ci and kubeflow-ci-deployment.

* Create a cron job for auto deploying 0.5
* Update the cron job for auto-deploying master.

* Cleanup leaked backends.

* Fix lint.

* Fix ci.

* Fix lint.

* --name shouldn't be required because we can read from snapshot file.

* --name shouldn't be required.
HumairAK referenced this issue in red-hat-data-services/data-science-pipelines Mar 11, 2024
@Tomcli
fix(sdk): Quick fix for sanitizing conditional variables (#344)
058c6c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gaoning777 gaoning777

Labels
area/sdk/dsl/compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@IronPan @gaoning777