Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Controller] Profile controller for multi user namespace initialization #3420

Closed
Bobgy opened this issue Apr 2, 2020 · 3 comments
Closed
Assignees
Labels

Comments

@Bobgy
Copy link
Contributor

Bobgy commented Apr 2, 2020

/cc @chensun @IronPan
Part of #3241

Per discussion with Kubeflow team, each application should have its own controller for configuring user namespaces with required resources.

Therefore, we should write KFP's profile controller that configures KFP required resources in each user's namespace.

Current list of required resources:

  • minio secret
  • mlmd grpc configmap

Resources we are considering:

  • visualization server
  • artifact fetcher server

I will start with minio secret and mlmd grpc configmap as a POC.

@Bobgy
Copy link
Contributor Author

Bobgy commented Apr 2, 2020

POC implementation in: Bobgy/manifests@cab423b

It is a deployment only solution, main logic is in Bobgy/manifests@cab423b#diff-762b01268bcc6313528cc44fffc68e77

Behavior:

  • It creates minio artifact secret and mlmd grpc configmap if they don't exist.
  • And if user has customized those resources, they won't be overwritten.
  • The design is to make sure KFP only initializes default configurations, while users can do their own customizations to the deployment.

References:

@Bobgy
Copy link
Contributor Author

Bobgy commented Apr 3, 2020

/close
Current list of required resources are supported.
Will open separate issues for future resources

@k8s-ci-robot
Copy link
Contributor

@Bobgy: Closing this issue.

In response to this:

/close
Current list of required resources are supported.
Will open separate issues for future resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants