Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set TTL for argo workflow #1708

Closed
IronPan opened this issue Jul 31, 2019 · 7 comments
Closed

Set TTL for argo workflow #1708

IronPan opened this issue Jul 31, 2019 · 7 comments

Comments

@IronPan
Copy link
Member

IronPan commented Jul 31, 2019

Argo supports ttl https://github.com/argoproj/argo/blob/master/examples/gc-ttl.yaml
When DSL compiles pipeline to argo workflow, we should set this so that it can be GCed after finish. The TTL should leave enough time for Persistence agent to persist the data.

@gaoning777
Copy link
Contributor

gaoning777 commented Jul 31, 2019

Are you suggesting a default ttl for all pipelines?
BTW, the DSL already exposes the ttl conf:

def set_ttl_seconds_after_finished(self, seconds: int):

@gaoning777
Copy link
Contributor

Is the purpose to reduce the storage size? in which case we can set the default value to a large number to prevent large pipelines from failing due to small ttl.

@paveldournov
Copy link
Contributor

The TTL seems to kick off after the workload completes, so we don't need to worry about long running workflows. I think we should consider setting a low TTL by default to GC the resources promptly after the run is recorded in metadata. It would probably affect the logging UX experience and we will need to switch over to showing the persisted logs (stackdriver, etc) instead by default.

@IronPan
Copy link
Member Author

IronPan commented Aug 10, 2019

With change #1802 this issue can be closed.

@IronPan
Copy link
Member Author

IronPan commented Aug 10, 2019

Agreed with @paveldournov we need find a better way to persist logs with aggressive GC.
For GCP stackdriver is ok.
For non-GCP, we need a better story.

@IronPan
Copy link
Member Author

IronPan commented Aug 10, 2019

File an issue for on-prem logs #1803
/close

@k8s-ci-robot
Copy link
Contributor

@IronPan: Closing this issue.

In response to this:

File an issue for on-prem logs #1803
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants