Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

func_to_container_op converting underscores to dashes #1135

Closed
kevinbache opened this issue Apr 11, 2019 · 5 comments
Closed

func_to_container_op converting underscores to dashes #1135

kevinbache opened this issue Apr 11, 2019 · 5 comments
Assignees
@Ark-kun
Labels
area/sdk/dsl/compiler kind/bug priority/p1

Comments

@kevinbache
Copy link
Contributor

func_to_container_op is converting underscores in NamedTuple output variables to dashes
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.85. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: dashboard, app homepage and code for this bot.

@issue-label-bot issue-label-bot bot added the bug label Apr 11, 2019
@jlewi jlewi added kind/bug and removed bug labels Apr 11, 2019
@kevinbache kevinbache changed the title func_to_container_op output problems func_to_container_op converting underscores to dashes Apr 11, 2019
@kevinbache
Copy link
Contributor Author

closing as dupe of #205

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 26, 2019

I'd say this is a separate issue. Technically, the keys of the task.outputs dictionary can be any strings.
We could even have spaces in them.

@gaoning777 Now that the sanitization has been moved to the compiler, what do you think about allowing more free-form/human-readable output names?

@Ark-kun Ark-kun reopened this Apr 26, 2019
@gaoning777
Copy link
Contributor

I'm all for it to keep the user interface consistent.

@Ark-kun
Copy link
Contributor

Ark-kun commented Sep 3, 2019

The naming rule change to the func_to_container_op (actually it was load_component) was done in #938

@Ark-kun Ark-kun closed this as completed Sep 3, 2019
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this issue Mar 11, 2024
@yhwang @Tomcli
fix(backend): Add format arg to printf command (kubeflow#1135)
3d7d79a 
add format arg to printf command to avoid cached string
being interpreted.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

Signed-off-by: Yihong Wang <yh.wang@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ark-kun Ark-kun

Labels
area/sdk/dsl/compiler kind/bug priority/p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jlewi @kevinbache @Ark-kun @gaoning777 @vicaire