fix link error to tf-laucher

kubeflow · Jan 30, 2019 · f361365 · f361365
1 parent 9d28907
commit f361365
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 8 deletions.
diff --git a/.cloudbuild.yaml b/.cloudbuild.yaml
@@ -123,8 +123,12 @@ steps:
   id: 'buildDeployer'
 - name: 'gcr.io/cloud-builders/docker'
   entrypoint: '/bin/bash'
-  args: ['-c', 'cd /workspace/components/kubeflow/launcher && ./build_image.sh -p $PROJECT_ID -t $COMMIT_SHA']
+  args: ['-c', 'cd /workspace/components/kubeflow/tf-launcher && ./build_image.sh -p $PROJECT_ID -t $COMMIT_SHA']
   id: 'buildLauncher'
+- name: 'gcr.io/cloud-builders/docker'
+  entrypoint: '/bin/bash'
+  args: ['-c', 'cd /workspace/components/kubeflow/katib-launcher && ./build_image.sh -p $PROJECT_ID -t $COMMIT_SHA']
+  id: 'buildKatibLauncher'
 - name: 'gcr.io/cloud-builders/docker'
   entrypoint: '/bin/bash'
   args: ['-c', 'cd /workspace/components/kubeflow/dnntrainer && ./build_image.sh -p $PROJECT_ID -t $COMMIT_SHA -l ml-pipeline-kubeflow-tf-trainer-gpu -b 1.6.0-gpu']

diff --git a/components/kubeflow/tf-launcher/test/test_launcher.py b/components/kubeflow/tf-launcher/test/test_launcher.py
@@ -14,7 +14,6 @@
 
 
 import launcher
-from launcher import train
 import os
 import shutil
 import subprocess
@@ -36,7 +35,7 @@ def test_yaml_generation_basic(self):
     pss = 1
     args_list = []
     args_list.append('--learning-rate=0.1')
-    generated_yaml = train._generate_train_yaml(train_template_file, tfjob_ns, worker, pss, args_list)
+    generated_yaml = _generate_train_yaml(train_template_file, tfjob_ns, worker, pss, args_list)
     with open(os.path.join(test_data_dir, 'train_basic.yaml'), 'r') as f:
       golden = yaml.load(f)
     self.assertEqual(golden, generated_yaml)
@@ -51,7 +50,7 @@ def test_yaml_generation_advanced(self):
     args_list = []
     tfjob_ns = 'kubeflow'
     args_list.append('--learning-rate=0.1')
-    generated_yaml = train._generate_train_yaml(train_template_file, tfjob_ns, worker, pss, args_list)
+    generated_yaml = _generate_train_yaml(train_template_file, tfjob_ns, worker, pss, args_list)
     with open(os.path.join(test_data_dir, 'train_zero_worker.yaml'), 'r') as f:
       golden = yaml.load(f)
     self.assertEqual(golden, generated_yaml)

diff --git a/samples/kubeflow-tf/README.md b/samples/kubeflow-tf/README.md
@@ -35,8 +35,8 @@ Preprocessing:
   [container](https://github.com/kubeflow/pipelines/tree/master/components/dataflow/tft)
 
 Training:
-  [source code](https://github.com/kubeflow/pipelines/tree/master/components/kubeflow/launcher/src), 
-  [container](https://github.com/kubeflow/pipelines/tree/master/components/kubeflow/launcher)
+  [source code](https://github.com/kubeflow/pipelines/tree/master/components/kubeflow/tf-launcher/src),
+  [container](https://github.com/kubeflow/pipelines/tree/master/components/kubeflow/tf-launcher)
 
 Prediction:
   [source code](https://github.com/kubeflow/pipelines/tree/master/components/dataflow/predict/src), 

diff --git a/samples/tfx/README.md b/samples/tfx/README.md
@@ -51,8 +51,8 @@ Preprocessing:
   [container](https://github.com/kubeflow/pipelines/tree/master/components/dataflow/tft)
 
 Training:
-  [source code](https://github.com/kubeflow/pipelines/tree/master/components/kubeflow/launcher/src) 
-  [container](https://github.com/kubeflow/pipelines/tree/master/components/kubeflow/launcher)
+  [source code](https://github.com/kubeflow/pipelines/tree/master/components/kubeflow/tf-launcher/src)
+  [container](https://github.com/kubeflow/pipelines/tree/master/components/kubeflow/tf-launcher)
 
 Analysis:
   [source code](https://github.com/kubeflow/pipelines/tree/master/components/dataflow/tfma/src)