Skip to content

Commit

Permalink
revert: "feat!: use argo emissary executor by default. Fixes #5718" (#…
Browse files Browse the repository at this point in the history
…6230)

This reverts commit 0c4129c.
  • Loading branch information
Bobgy authored Aug 4, 2021
1 parent 0b82ef9 commit e6df7db
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ data:
# * https://github.com/argoproj/argo-workflows/blob/v3.1.2/docs/workflow-controller-configmap.md
# * https://github.com/argoproj/argo-workflows/blob/v3.1.2/docs/workflow-controller-configmap.yaml

containerRuntimeExecutor: emissary
containerRuntimeExecutor: docker

# Note, {{ `some-string-{{without}}-template-interpretation` }} is a way to avoid some brackets interpreted as template.
# Reference: https://github.com/helm/helm/issues/2798#issuecomment-467319526
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ data:
# * https://github.com/argoproj/argo-workflows/blob/v3.1.2/docs/workflow-controller-configmap.yaml

# emissary executor is a more portable default, see https://github.com/kubeflow/pipelines/issues/1654.
containerRuntimeExecutor: emissary
containerRuntimeExecutor: docker

# In artifactRepository.s3.endpoint, $(kfp-namespace) is needed, because in multi-user mode, pipelines may run in other namespaces.
artifactRepository: |
Expand Down

0 comments on commit e6df7db

Please sign in to comment.