Skip to content

Commit

Permalink
[MKP] Remove service account credential from deployment page. (#2308)
Browse files Browse the repository at this point in the history
* Finalize. Add todo

* Remove
  • Loading branch information
Jiaxiao Zheng authored and k8s-ci-robot committed Oct 9, 2019
1 parent 6a8d105 commit ca17faa
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ images:
metadataenvoy: gcr.io/ml-pipeline/google/pipelines/metadataenvoy:0.1.31

gcpSecretName: "user-gcp-sa"
serviceAccountCredential: null
serviceAccountCredential: ""

managedstorage:
enabled: false
Expand Down
16 changes: 2 additions & 14 deletions manifests/gcp_marketplace/schema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -100,20 +100,8 @@ properties:
type: string
x-google-marketplace:
type: NAMESPACE
serviceAccountCredential:
title: |-
GCP Service Account credentials used to call other GCP services.
description: |-
This deployment requires a service account to use for authentication when calling other GCP services.
Specify the base64-encoded credentials for the service account you want to use.
You can get these credentials by running the following command in a terminal window.
\"$ gcloud iam service-accounts keys create application_default_credentials.json --iam-account [your-service-account] && cat application_default_credentials.json | base64\"
If you are using Linux, please use \"base64 -w 0\" to disable line wrapping.
type: string
default: ""
x-google-marketplace:
type: STRING

required:
- name
- namespace
- serviceAccountCredential

0 comments on commit ca17faa

Please sign in to comment.