Upgrade prettier

frontend/package.json

@@ -84,7 +84,7 @@
     "enzyme": "^3.10.0",
     "enzyme-adapter-react-16": "^1.15.1",
     "enzyme-to-json": "^3.3.4",
-    "prettier": "1.18.2",
+    "prettier": "^1.19.1",
     "react-router-test-context": "^0.1.0",
     "react-scripts": "^3.4.0",
     "react-test-renderer": "^16.5.2",

frontend/src/apis/run/api.ts

@@ -1486,10 +1486,12 @@ export const RunServiceApiFactory = function(
      * @throws {RequiredError}
      */
     readArtifact(run_id: string, node_id: string, artifact_name: string, options?: any) {
-      return RunServiceApiFp(configuration).readArtifact(run_id, node_id, artifact_name, options)(
-        fetch,
-        basePath,
-      );
+      return RunServiceApiFp(configuration).readArtifact(
+        run_id,
+        node_id,
+        artifact_name,
+        options,
+      )(fetch, basePath);
     },
     /**
      *
@@ -1500,10 +1502,11 @@ export const RunServiceApiFactory = function(
      * @throws {RequiredError}
      */
     reportRunMetrics(run_id: string, body: ApiReportRunMetricsRequest, options?: any) {
-      return RunServiceApiFp(configuration).reportRunMetrics(run_id, body, options)(
-        fetch,
-        basePath,
-      );
+      return RunServiceApiFp(configuration).reportRunMetrics(
+        run_id,
+        body,
+        options,
+      )(fetch, basePath);
     },
     /**
      *
@@ -1661,10 +1664,11 @@ export class RunServiceApi extends BaseAPI {
    * @memberof RunServiceApi
    */
   public reportRunMetrics(run_id: string, body: ApiReportRunMetricsRequest, options?: any) {
-    return RunServiceApiFp(this.configuration).reportRunMetrics(run_id, body, options)(
-      this.fetch,
-      this.basePath,
-    );
+    return RunServiceApiFp(this.configuration).reportRunMetrics(
+      run_id,
+      body,
+      options,
+    )(this.fetch, this.basePath);
   }
 
   /**

frontend/src/atoms/ExternalLink.tsx

@@ -14,16 +14,18 @@ const css = stylesheet({
   },
 });
 
-export const ExternalLink: React.FC<
-  DetailedHTMLProps<AnchorHTMLAttributes<HTMLAnchorElement>, HTMLAnchorElement>
-> = props => (
+export const ExternalLink: React.FC<DetailedHTMLProps<
+  AnchorHTMLAttributes<HTMLAnchorElement>,
+  HTMLAnchorElement
+>> = props => (
   // eslint-disable-next-line jsx-a11y/anchor-has-content
   <a {...props} className={css.link} target='_blank' rel='noopener' />
 );
 
-export const AutoLink: React.FC<
-  DetailedHTMLProps<AnchorHTMLAttributes<HTMLAnchorElement>, HTMLAnchorElement>
-> = props =>
+export const AutoLink: React.FC<DetailedHTMLProps<
+  AnchorHTMLAttributes<HTMLAnchorElement>,
+  HTMLAnchorElement
+>> = props =>
   props.href && props.href.startsWith('#') ? (
     // eslint-disable-next-line jsx-a11y/anchor-has-content
     <a {...props} className={css.link} />

frontend/src/components/CompareTable.test.tsx

@@ -37,7 +37,11 @@ describe('CompareTable', () => {
     expect(tree).toMatchSnapshot();
   });
 
-  const rows = [['1', '2', '3'], ['4', '5', '6'], ['cell7', 'cell8', 'cell9']];
+  const rows = [
+    ['1', '2', '3'],
+    ['4', '5', '6'],
+    ['cell7', 'cell8', 'cell9'],
+  ];
   const xLabels = ['col1', 'col2', 'col3'];
   const yLabels = ['row1', 'row2', 'row3'];
 

frontend/src/components/CustomTableRow.test.tsx

@@ -43,7 +43,7 @@ describe('CustomTable', () => {
   };
 
   it('renders some rows using a custom renderer', async () => {
-    columns[0].customRenderer = () => <span>this is custom output</span> as any;
+    columns[0].customRenderer = () => (<span>this is custom output</span>) as any;
     const tree = shallow(<CustomTableRow {...props} row={row} columns={columns} />);
     await TestUtils.flushPromises();
     expect(tree).toMatchSnapshot();

frontend/src/components/DetailsTable.test.tsx

@@ -95,7 +95,14 @@ describe('DetailsTable', () => {
   });
 
   it('does not render booleans as JSON', () => {
-    const tree = shallow(<DetailsTable fields={[['key1', 'true'], ['key2', 'false']]} />);
+    const tree = shallow(
+      <DetailsTable
+        fields={[
+          ['key1', 'true'],
+          ['key2', 'false'],
+        ]}
+      />,
+    );
     expect(tree).toMatchSnapshot();
   });
 

frontend/src/components/viewers/ConfusionMatrix.test.tsx

@@ -25,7 +25,11 @@ describe('ConfusionMatrix', () => {
     expect(tree).toMatchSnapshot();
   });
 
-  const data = [[0, 1, 2], [3, 4, 5], [6, 7, 8]];
+  const data = [
+    [0, 1, 2],
+    [3, 4, 5],
+    [6, 7, 8],
+  ];
   const config: ConfusionMatrixConfig = {
     axes: ['test x axis', 'test y axis'],
     data,

frontend/src/components/viewers/PagedTable.test.tsx

@@ -30,7 +30,10 @@ describe('PagedTable', () => {
     expect(tree).toMatchSnapshot();
   });
 
-  const data = [['col1', 'col2', 'col3'], ['col4', 'col5', 'col6']];
+  const data = [
+    ['col1', 'col2', 'col3'],
+    ['col4', 'col5', 'col6'],
+  ];
   const labels = ['field1', 'field2', 'field3'];
 
   it('renders simple data', () => {

frontend/src/lib/CompareUtils.test.ts

@@ -266,7 +266,10 @@ describe('CompareUtils', () => {
         } as ApiRun,
       ];
       expect(CompareUtils.multiRunMetricsCompareProps(runs)).toEqual({
-        rows: [['0.330', ''], ['', '0.660']],
+        rows: [
+          ['0.330', ''],
+          ['', '0.660'],
+        ],
         xLabels: ['run1', 'run2'],
         yLabels: ['some-metric', 'another-metric'],
       });
@@ -396,7 +399,10 @@ describe('CompareUtils', () => {
         name: 'run1',
       } as ApiRun;
       expect(CompareUtils.singleRunToMetricsCompareProps(run)).toEqual({
-        rows: [['0.230', ''], ['', '0.540']],
+        rows: [
+          ['0.230', ''],
+          ['', '0.540'],
+        ],
         xLabels: ['some-metric-name', 'another-metric-name'],
         yLabels: ['someNodeId', 'anotherNodeId'],
       });

frontend/src/lib/OutputArtifactLoader.test.ts

@@ -168,7 +168,10 @@ describe('OutputArtifactLoader', () => {
       const result = await OutputArtifactLoader.buildConfusionMatrixConfig(metadata as any);
       expect(result).toEqual({
         axes: ['field1', 'field2'],
-        data: [[0, 0], [0, 0]],
+        data: [
+          [0, 0],
+          [0, 0],
+        ],
         labels: ['field1', 'field2'],
         type: PlotType.CONFUSION_MATRIX,
       } as ConfusionMatrixConfig);
@@ -372,7 +375,11 @@ describe('OutputArtifactLoader', () => {
         6,7,8
       `;
       expect(await OutputArtifactLoader.buildRocCurveConfig(metadata as any)).toEqual({
-        data: [{ label: '2', x: 0, y: 1 }, { label: '5', x: 3, y: 4 }, { label: '8', x: 6, y: 7 }],
+        data: [
+          { label: '2', x: 0, y: 1 },
+          { label: '5', x: 3, y: 4 },
+          { label: '8', x: 6, y: 7 },
+        ],
         type: PlotType.ROC,
       } as ROCCurveConfig);
     });
@@ -388,7 +395,11 @@ describe('OutputArtifactLoader', () => {
         6,7,8
       `;
       expect(await OutputArtifactLoader.buildRocCurveConfig(metadata as any)).toEqual({
-        data: [{ label: '0', x: 2, y: 1 }, { label: '3', x: 5, y: 4 }, { label: '6', x: 8, y: 7 }],
+        data: [
+          { label: '0', x: 2, y: 1 },
+          { label: '3', x: 5, y: 4 },
+          { label: '6', x: 8, y: 7 },
+        ],
         type: PlotType.ROC,
       } as ROCCurveConfig);
     });
@@ -404,7 +415,11 @@ describe('OutputArtifactLoader', () => {
         6,7,8
       `;
       expect(await OutputArtifactLoader.buildRocCurveConfig(metadata as any)).toEqual({
-        data: [{ label: '2', x: 0, y: 1 }, { label: '5', x: 3, y: 4 }, { label: '8', x: 6, y: 7 }],
+        data: [
+          { label: '2', x: 0, y: 1 },
+          { label: '5', x: 3, y: 4 },
+          { label: '8', x: 6, y: 7 },
+        ],
         type: PlotType.ROC,
       } as ROCCurveConfig);
     });

frontend/src/lib/StaticGraphParser.test.ts

@@ -593,13 +593,19 @@ describe('StaticGraphParser', () => {
         container: {},
         dag: [],
         inputs: {
-          parameters: [{ name: 'param1', value: 'val1' }, { name: 'param2', value: 'val2' }],
+          parameters: [
+            { name: 'param1', value: 'val1' },
+            { name: 'param2', value: 'val2' },
+          ],
         },
         name: 'template-1',
       } as any;
       const nodeInfo = _populateInfoFromTemplate(new SelectedNodeInfo(), template);
       expect(nodeInfo.nodeType).toEqual('container');
-      expect(nodeInfo.inputs).toEqual([['param1', 'val1'], ['param2', 'val2']]);
+      expect(nodeInfo.inputs).toEqual([
+        ['param1', 'val1'],
+        ['param2', 'val2'],
+      ]);
     });
 
     it('returns nodeInfo of a container with empty strings for inputs with no specified value', () => {
@@ -613,7 +619,10 @@ describe('StaticGraphParser', () => {
       } as any;
       const nodeInfo = _populateInfoFromTemplate(new SelectedNodeInfo(), template);
       expect(nodeInfo.nodeType).toEqual('container');
-      expect(nodeInfo.inputs).toEqual([['param1', ''], ['param2', '']]);
+      expect(nodeInfo.inputs).toEqual([
+        ['param1', ''],
+        ['param2', ''],
+      ]);
     });
 
     it('returns nodeInfo containing container outputs as list of name/value tuples, pulling from valueFrom if necessary', () => {
@@ -651,7 +660,10 @@ describe('StaticGraphParser', () => {
       } as any;
       const nodeInfo = _populateInfoFromTemplate(new SelectedNodeInfo(), template);
       expect(nodeInfo.nodeType).toEqual('container');
-      expect(nodeInfo.outputs).toEqual([['param1', ''], ['param2', '']]);
+      expect(nodeInfo.outputs).toEqual([
+        ['param1', ''],
+        ['param2', ''],
+      ]);
     });
 
     it('returns nodeInfo of a resource with empty values if template does not have inputs and/or outputs', () => {
@@ -672,14 +684,20 @@ describe('StaticGraphParser', () => {
       const template = {
         dag: [],
         inputs: {
-          parameters: [{ name: 'param1', value: 'val1' }, { name: 'param2', value: 'val2' }],
+          parameters: [
+            { name: 'param1', value: 'val1' },
+            { name: 'param2', value: 'val2' },
+          ],
         },
         name: 'template-1',
         resource: {},
       } as any;
       const nodeInfo = _populateInfoFromTemplate(new SelectedNodeInfo(), template);
       expect(nodeInfo.nodeType).toEqual('resource');
-      expect(nodeInfo.inputs).toEqual([['param1', 'val1'], ['param2', 'val2']]);
+      expect(nodeInfo.inputs).toEqual([
+        ['param1', 'val1'],
+        ['param2', 'val2'],
+      ]);
     });
 
     it('returns nodeInfo of a resource with empty strings for inputs with no specified value', () => {
@@ -693,7 +711,10 @@ describe('StaticGraphParser', () => {
       } as any;
       const nodeInfo = _populateInfoFromTemplate(new SelectedNodeInfo(), template);
       expect(nodeInfo.nodeType).toEqual('resource');
-      expect(nodeInfo.inputs).toEqual([['param1', ''], ['param2', '']]);
+      expect(nodeInfo.inputs).toEqual([
+        ['param1', ''],
+        ['param2', ''],
+      ]);
     });
 
     it('returns nodeInfo containing resource outputs as list of name/value tuples, pulling from valueFrom if necessary', () => {
@@ -731,7 +752,10 @@ describe('StaticGraphParser', () => {
       } as any;
       const nodeInfo = _populateInfoFromTemplate(new SelectedNodeInfo(), template);
       expect(nodeInfo.nodeType).toEqual('resource');
-      expect(nodeInfo.outputs).toEqual([['param1', ''], ['param2', '']]);
+      expect(nodeInfo.outputs).toEqual([
+        ['param1', ''],
+        ['param2', ''],
+      ]);
     });
   });
 });

frontend/src/pages/AllRunsList.tsx

@@ -46,8 +46,10 @@ class AllRunsList extends Page<{}, AllRunsListState> {
         .newExperiment()
         .compareRuns(() => this.state.selectedIds)
         .cloneRun(() => this.state.selectedIds, false)
-        .archive(() => this.state.selectedIds, false, selectedIds =>
-          this._selectionChanged(selectedIds),
+        .archive(
+          () => this.state.selectedIds,
+          false,
+          selectedIds => this._selectionChanged(selectedIds),
         )
         .refresh(this.refresh.bind(this))
         .getToolbarActionMap(),

frontend/src/pages/Compare.test.tsx

@@ -242,7 +242,10 @@ describe('Compare', () => {
     const workflow = {
       spec: {
         arguments: {
-          parameters: [{ name: 'param1', value: 'value1' }, { name: 'param2', value: 'value2' }],
+          parameters: [
+            { name: 'param1', value: 'value1' },
+            { name: 'param2', value: 'value2' },
+          ],
         },
       },
     } as Workflow;

frontend/src/pages/ExperimentDetails.test.tsx

@@ -369,7 +369,10 @@ describe('ExperimentDetails', () => {
   });
 
   it('navigates to the compare runs page', async () => {
-    const runs = [{ id: 'run-1-id', name: 'run-1' }, { id: 'run-2-id', name: 'run-2' }];
+    const runs = [
+      { id: 'run-1-id', name: 'run-1' },
+      { id: 'run-2-id', name: 'run-2' },
+    ];
     listRunsSpy.mockImplementation(() => ({ runs }));
     await listRunsSpy;
 

frontend/src/pages/ExperimentDetails.tsx

@@ -123,7 +123,11 @@ class ExperimentDetails extends Page<{}, ExperimentDetailsState> {
           .newRecurringRun(this.props.match.params[RouteParams.experimentId])
           .compareRuns(() => this.state.selectedIds)
           .cloneRun(() => this.state.selectedIds, false)
-          .archive(() => this.state.selectedIds, false, ids => this._selectionChanged(ids))
+          .archive(
+            () => this.state.selectedIds,
+            false,
+            ids => this._selectionChanged(ids),
+          )
           .getToolbarActionMap(),
         breadcrumbs: [],
         pageTitle: 'Runs',

frontend/src/pages/ExperimentList.tsx

@@ -72,7 +72,11 @@ class ExperimentList extends Page<{}, ExperimentListState> {
         .newExperiment()
         .compareRuns(() => this.state.selectedIds)
         .cloneRun(() => this.state.selectedIds, false)
-        .archive(() => this.state.selectedIds, false, ids => this._selectionChanged(ids))
+        .archive(
+          () => this.state.selectedIds,
+          false,
+          ids => this._selectionChanged(ids),
+        )
         .refresh(this.refresh.bind(this))
         .getToolbarActionMap(),
       breadcrumbs: [],