new kubernetes packages contain breaking change, thus fixing the vers…

…ion in the sample test image (#1159) * new kubernetes packages contain breaking change, thus fixing the version * also fixing the kubernetes version in the python sdk dependency * fix bug
kubeflow · Apr 15, 2019 · 71325c3 · 71325c3
1 parent c0da565
commit 71325c3
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/samples/notebooks/KubeFlow Pipeline Using TFX OSS Components.ipynb b/samples/notebooks/KubeFlow Pipeline Using TFX OSS Components.ipynb
@@ -762,7 +762,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.5.4rc1"
+   "version": "3.6.5"
   }
  },
  "nbformat": 4,

diff --git a/sdk/python/kfp/compiler/_k8s_helper.py b/sdk/python/kfp/compiler/_k8s_helper.py
@@ -95,7 +95,7 @@ def _wait_for_k8s_job(self, pod_name, yaml_spec, timeout):
   def _delete_k8s_job(self, pod_name, yaml_spec):
     """ _delete_k8s_job deletes a pod """
     try:
-      api_response = self._corev1.delete_namespaced_pod(pod_name, yaml_spec['metadata']['namespace'], k8s_client.V1DeleteOptions())
+      api_response = self._corev1.delete_namespaced_pod(pod_name, yaml_spec['metadata']['namespace'], body=k8s_client.V1DeleteOptions())
     except k8s_client.rest.ApiException as e:
       logging.exception('Exception when calling CoreV1Api->delete_namespaced_pod: {}\n'.format(str(e)))
 

diff --git a/sdk/python/setup.py b/sdk/python/setup.py
@@ -24,7 +24,7 @@
     'python-dateutil',
     'PyYAML',
     'google-cloud-storage>=1.13.0',
-    'kubernetes>=8.0.0',
+    'kubernetes>=8.0.0, <=9.0.0',
     'PyJWT>=1.6.4',
     'cryptography>=2.4.2',
     'google-auth>=1.6.1',

diff --git a/test/sample-test/Dockerfile b/test/sample-test/Dockerfile
@@ -11,7 +11,7 @@ RUN wget http://central.maven.org/maven2/io/swagger/swagger-codegen-cli/2.4.1/sw
 
 RUN pip3 install wheel
 RUN pip3 install junit-xml
-RUN pip3 install kubernetes
+RUN pip3 install kubernetes==9.0.0
 RUN pip3 install minio
 RUN pip3 install setuptools==40.5.0
 RUN pip3 install papermill==0.16.1