Update, fix tests

kubeflow · Aug 15, 2019 · 627667f · 627667f
1 parent d38db17
commit 627667f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 15 deletions.
diff --git a/frontend/src/lib/Utils.test.ts b/frontend/src/lib/Utils.test.ts
@@ -114,7 +114,7 @@ describe('Utils', () => {
 
     it('computes seconds', () => {
       const run = {
-        created_at: new Date(2018, 1, 2, 3, 55, 30).toISOString(),
+        created_at: new Date(2018, 1, 3, 3, 55, 30).toISOString(),
         finished_at: new Date(2018, 1, 3, 3, 56, 25).toISOString(),
         status: NodePhase.SUCCEEDED,
       } as any;
@@ -123,29 +123,29 @@ describe('Utils', () => {
 
     it('computes minutes/seconds', () => {
       const run = {
-        created_at: new Date(2018, 1, 2, 3, 55, 10).toISOString(),
+        created_at: new Date(2018, 1, 3, 3, 55, 10).toISOString(),
         finished_at: new Date(2018, 1, 3, 3, 59, 25).toISOString(),
         status: NodePhase.SUCCEEDED,
       } as any;
       expect(getRunDuration(run)).toBe('0:04:15');
     });
 
-    it('computes days/minutes/seconds', () => {
+    it('computes hours/minutes/seconds', () => {
       const run = {
         created_at: new Date(2018, 1, 2, 3, 55, 10).toISOString(),
         finished_at: new Date(2018, 1, 3, 4, 55, 10).toISOString(),
         status: NodePhase.SUCCEEDED,
       } as any;
-      expect(getRunDuration(run)).toBe('1:00:00');
+      expect(getRunDuration(run)).toBe('25:00:00');
     });
 
-    it('computes padded days/minutes/seconds', () => {
+    it('computes padded hours/minutes/seconds', () => {
       const run = {
         created_at: new Date(2018, 1, 2, 3, 55, 10).toISOString(),
         finished_at: new Date(2018, 1, 3, 4, 56, 11).toISOString(),
         status: NodePhase.SUCCEEDED,
       } as any;
-      expect(getRunDuration(run)).toBe('1:01:01');
+      expect(getRunDuration(run)).toBe('25:01:01');
     });
 
     it('shows negative sign if start date is after end date', () => {
@@ -190,7 +190,7 @@ describe('Utils', () => {
       const workflow = {
         status: {
           finishedAt: new Date(2018, 1, 3, 3, 56, 25).toISOString(),
-          startedAt: new Date(2018, 1, 2, 3, 55, 30).toISOString(),
+          startedAt: new Date(2018, 1, 3, 3, 55, 30).toISOString(),
         }
       } as any;
       expect(getRunDurationFromWorkflow(workflow)).toBe('0:00:55');
@@ -200,27 +200,27 @@ describe('Utils', () => {
       const workflow = {
         status: {
           finishedAt: new Date(2018, 1, 3, 3, 59, 25).toISOString(),
-          startedAt: new Date(2018, 1, 2, 3, 55, 10).toISOString(),
+          startedAt: new Date(2018, 1, 3, 3, 55, 10).toISOString(),
         }
       } as any;
       expect(getRunDurationFromWorkflow(workflow)).toBe('0:04:15');
     });
 
-    it('computes days/minutes/seconds run time if status is provided', () => {
+    it('computes hours/minutes/seconds run time if status is provided', () => {
       const workflow = {
         status: {
           finishedAt: new Date(2018, 1, 3, 4, 55, 10).toISOString(),
-          startedAt: new Date(2018, 1, 2, 3, 55, 10).toISOString(),
+          startedAt: new Date(2018, 1, 3, 3, 55, 10).toISOString(),
         }
       } as any;
       expect(getRunDurationFromWorkflow(workflow)).toBe('1:00:00');
     });
 
-    it('computes padded days/minutes/seconds run time if status is provided', () => {
+    it('computes padded hours/minutes/seconds run time if status is provided', () => {
       const workflow = {
         status: {
           finishedAt: new Date(2018, 1, 3, 4, 56, 11).toISOString(),
-          startedAt: new Date(2018, 1, 2, 3, 55, 10).toISOString(),
+          startedAt: new Date(2018, 1, 3, 3, 55, 10).toISOString(),
         }
       } as any;
       expect(getRunDurationFromWorkflow(workflow)).toBe('1:01:01');

diff --git a/frontend/src/pages/__snapshots__/RunDetails.test.tsx.snap b/frontend/src/pages/__snapshots__/RunDetails.test.tsx.snap
@@ -1835,7 +1835,7 @@ exports[`RunDetails shows run config fields - handles no description 1`] = `
               ],
               Array [
                 "Duration",
-                "1:01:01",
+                "25:01:01",
               ],
             ]
           }
@@ -1896,7 +1896,7 @@ exports[`RunDetails shows run config fields - handles no metadata 1`] = `
               ],
               Array [
                 "Duration",
-                "1:01:01",
+                "25:01:01",
               ],
             ]
           }
@@ -1957,7 +1957,7 @@ exports[`RunDetails shows run config fields 1`] = `
               ],
               Array [
                 "Duration",
-                "1:01:01",
+                "25:01:01",
               ],
             ]
           }