Skip to content

Commit

Permalink
Add %%docker magic to jupyter kernel. It helps submitting a docker bu…
Browse files Browse the repository at this point in the history
…ild job more easily with one cell. (#72)
  • Loading branch information
qimingj authored and k8s-ci-robot committed Nov 6, 2018
1 parent e6a4c9f commit 458c817
Show file tree
Hide file tree
Showing 3 changed files with 59 additions and 0 deletions.
16 changes: 16 additions & 0 deletions sdk/python/kfp/notebook/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# Copyright 2018 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.


from . import _magic
42 changes: 42 additions & 0 deletions sdk/python/kfp/notebook/_magic.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
# Copyright 2018 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.


try:
import IPython
import IPython.core.magic
except ImportError:
raise Exception('This module can only be loaded in Jupyter.')


from kfp.compiler import build_docker_image
import tempfile


@IPython.core.magic.register_cell_magic
def docker(line, cell):
"""cell magic for %%docker"""

if len(line.split()) != 2:
raise ValueError("usage: %%docker [gcr.io/project/image:tag] [gs://staging-bucket]")
if not cell.strip():
raise ValueError("Please fill in a dockerfile content in the cell.")

target, staging = line.split()

with tempfile.NamedTemporaryFile(mode='wt') as f:
f.write(cell)
build_docker_image(staging, target, f.name)


1 change: 1 addition & 0 deletions sdk/python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
'kfp.compiler',
'kfp.components',
'kfp.dsl',
'kfp.notebook',
'kfp_experiment',
'kfp_experiment.api',
'kfp_experiment.models',
Expand Down

0 comments on commit 458c817

Please sign in to comment.