-
Notifications
You must be signed in to change notification settings - Fork 34
Conversation
Hi @wackxu. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
BTW, gometalinter is not maintained. Maybe we need to replace it in the future.
/hold |
I am fixing some CI error |
Travis tests have failedHey @wackxu, TravisBuddy Request Identifier: ac010d30-761d-11e9-9d9a-7d45cee0fd8a |
Travis tests have failedHey @wackxu, TravisBuddy Request Identifier: 8af8e400-7627-11e9-9d9a-7d45cee0fd8a |
Travis tests have failedHey @wackxu, TravisBuddy Request Identifier: e839beb0-763a-11e9-9d9a-7d45cee0fd8a |
Travis tests have failedHey @wackxu, TravisBuddy Request Identifier: c48e82a0-763c-11e9-9d9a-7d45cee0fd8a |
Travis tests have failedHey @wackxu, TravisBuddy Request Identifier: f2ebade0-764a-11e9-9d9a-7d45cee0fd8a |
|
@jlewi @abhi-g @gaocegege Could you help configure mxnet-operator repo on https://coveralls.io? |
We need @jlewi 's help |
Travis tests have failedHey @wackxu, TravisBuddy Request Identifier: 404f7f30-770e-11e9-baaa-abbb666ca5a5 |
@google-team@kubeflow.org We need help to configure the repo. |
@jlewi @johnugeorge Could your take a look at this. |
/hold cancel |
I asked @jlewi in slack but no response. Please wait. |
/hold |
@gaocegege Got it, thanks |
Jeremy will be busy with Kubecon this week |
@gaocegege @wackxu I enabled coveralls, it should work now. |
/hold cancel |
@gaocegege @suleisl2000 We can merge this now |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks for your contribution!
@wackxu Maybe you could be a member of the org, then the test will be triggered automatically. |
@gaocegege I have apply to be member in the https://github.com/kubeflow/internal-acls repo and that was merged. Anything else needs to be done to be a member? |
@wackxu You could ask for help in the slack #community channel if you are not invited in the next 2 weeks. |
@gaocegege Got it, thanks very much. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege, suleisl2000 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@suleisl2000 @gaocegege
This change is