Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

add travis.yml to mxnet-operator #37

Merged
merged 3 commits into from
May 21, 2019
Merged

Conversation

wackxu
Copy link
Contributor

@wackxu wackxu commented May 14, 2019

@suleisl2000 @gaocegege


This change is Reviewable

@k8s-ci-robot
Copy link

Hi @wackxu. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

BTW, gometalinter is not maintained. Maybe we need to replace it in the future.

@wackxu
Copy link
Contributor Author

wackxu commented May 14, 2019

/hold

@wackxu
Copy link
Contributor Author

wackxu commented May 14, 2019

I am fixing some CI error

@TravisBuddy
Copy link

Travis tests have failed

Hey @wackxu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: ac010d30-761d-11e9-9d9a-7d45cee0fd8a

@TravisBuddy
Copy link

Travis tests have failed

Hey @wackxu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 8af8e400-7627-11e9-9d9a-7d45cee0fd8a

@TravisBuddy
Copy link

Travis tests have failed

Hey @wackxu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: e839beb0-763a-11e9-9d9a-7d45cee0fd8a

@TravisBuddy
Copy link

Travis tests have failed

Hey @wackxu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: c48e82a0-763c-11e9-9d9a-7d45cee0fd8a

@TravisBuddy
Copy link

Travis tests have failed

Hey @wackxu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: f2ebade0-764a-11e9-9d9a-7d45cee0fd8a

@wackxu
Copy link
Contributor Author

wackxu commented May 14, 2019

image
@gaocegege @suleisl2000 Have you ever seen this error? Do we need some config on https://coveralls.io

@wackxu
Copy link
Contributor Author

wackxu commented May 15, 2019

@jlewi @abhi-g @gaocegege Could you help configure mxnet-operator repo on https://coveralls.io?

@gaocegege
Copy link
Member

We need @jlewi 's help

@TravisBuddy
Copy link

Travis tests have failed

Hey @wackxu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 404f7f30-770e-11e9-baaa-abbb666ca5a5

@wackxu
Copy link
Contributor Author

wackxu commented May 16, 2019

@google-team@kubeflow.org We need help to configure the repo.

@wackxu
Copy link
Contributor Author

wackxu commented May 17, 2019

@jlewi @johnugeorge Could your take a look at this.

@wackxu
Copy link
Contributor Author

wackxu commented May 20, 2019

/hold cancel

@gaocegege
Copy link
Member

I asked @jlewi in slack but no response. Please wait.

@wackxu
Copy link
Contributor Author

wackxu commented May 20, 2019

/hold
@gaocegege ok, Could you invite me to the kubeflow slack?

@wackxu
Copy link
Contributor Author

wackxu commented May 20, 2019

@gaocegege Got it, thanks

@johnugeorge
Copy link
Member

Jeremy will be busy with Kubecon this week

@richardsliu
Copy link

@gaocegege @wackxu I enabled coveralls, it should work now.

@wackxu
Copy link
Contributor Author

wackxu commented May 21, 2019

/hold cancel

@wackxu
Copy link
Contributor Author

wackxu commented May 21, 2019

@gaocegege @suleisl2000 We can merge this now

@gaocegege
Copy link
Member

/ok-to-test

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for your contribution!

@gaocegege
Copy link
Member

@wackxu Maybe you could be a member of the org, then the test will be triggered automatically.

@wackxu
Copy link
Contributor Author

wackxu commented May 21, 2019

@gaocegege I have apply to be member in the https://github.com/kubeflow/internal-acls repo and that was merged. Anything else needs to be done to be a member?

@gaocegege
Copy link
Member

gaocegege commented May 21, 2019

@wackxu You could ask for help in the slack #community channel if you are not invited in the next 2 weeks.

@wackxu
Copy link
Contributor Author

wackxu commented May 21, 2019

@gaocegege Got it, thanks very much.

@suleisl2000
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, suleisl2000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4f86134 into kubeflow:master May 21, 2019
@wackxu wackxu deleted the travisci branch June 13, 2019 06:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants