Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Knative serving to 0.11.1 #651

Merged
merged 6 commits into from
Jan 30, 2020
Merged

Upgrade Knative serving to 0.11.1 #651

merged 6 commits into from
Jan 30, 2020

Conversation

yuzisun
Copy link
Member

@yuzisun yuzisun commented Dec 8, 2019 •
edited
Loading

Which issue is resolved by this Pull Request:
Resolves kserve/kserve#629

Description of your changes:

  • taking knative 0.11.1 release and update kubeflow knative manifests, now minimum kube version is 1.14 and install all knative crds for v1alpha1, v1beta1, v1.
  • removed knative gateway which is conflicting with kubeflow gateway
  • change config-istio to point to kubeflow gateway
  • change kfserving config to point to kubeflow gateway

Checklist:

  • [ x] Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate
    3. make test

This change is Reviewable

@yuzisun yuzisun mentioned this pull request Dec 8, 2019
Merged
@animeshsingh
Copy link
Contributor

Thanks @yuzisun ! Putting this on hold for a while until we resolve knative 0.10 move in kfserving

/hold

krishnadurai
krishnadurai suggested changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@krishnadurai krishnadurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuzisun
I've left a few comments which need to be addressed.

@yuzisun yuzisun changed the title Upgrade Knative serving to 0.10.0 Upgrade Knative serving to 0.11.1 Jan 19, 2020
@yuzisun yuzisun mentioned this pull request Jan 25, 2020
Merged
@yuzisun
Copy link
Member Author

yuzisun commented Jan 25, 2020

/retest

@yuzisun yuzisun force-pushed the knative-0.10 branch 2 times, most recently from a90289c to af4705a Compare January 25, 2020 23:26
@yuzisun
Copy link
Member Author

yuzisun commented Jan 26, 2020

following tests are failing..
E kubeflow.testing.util.TimeoutError: Timeout waiting for deployment katib-manager in namespace kubeflow
E kubeflow.testing.util.TimeoutError: Timeout waiting for deployment cloud-endpoints-controller in namespace kubeflow

@ukclivecox ukclivecox mentioned this pull request Jan 28, 2020
Merged
@jlewi
Copy link
Contributor

jlewi commented Jan 28, 2020

Here are a couple options

  1. You can figure out why the tests are failing

    • You can use stackdriver to track down the event logs for the deployments that timed out to
      see what happened.

  2. You can modify the test config to opt out of testing for knative

krishnadurai
krishnadurai approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@krishnadurai krishnadurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@animeshsingh
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshsingh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuzisun
Copy link
Member Author

yuzisun commented Jan 30, 2020

/unhold

@yuzisun
Copy link
Member Author

yuzisun commented Jan 30, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit b1c2dac into kubeflow:master Jan 30, 2020
k8s-ci-robot pushed a commit that referenced this pull request Feb 11, 2020
@animeshsingh @yuzisun @krishnadurai
Automated cherry pick of #651: Update kfserving manifests to 0.2.1 #875…
9b1b254 
…: Cluster local gateway Istio Gateway manifests This is #876: Cluster local gateway for Istio 1.1.6 Cherry pick of #651 #875 #876 on v1.0-branch. #651: Update kfserving manifests to 0.2.1 #875: Cluster local gateway Istio Gateway manifests This is #876: Cluster local gateway for Istio 1.1.6 (#886)

* Update kfserving manifests to 0.2.1

* knative 0.10 upgrade

* Update knative test

* Upgrade to knative 0.11

* Update knative 0.11.1 tests

* Point to kubeflow gateway for kfserving

* Cluster local gateway Istio Gateway manifests This is required for KFServing's internal routing

* Adds test for cluster-local-gateway

* KFServing added to istio-dex config

* Corrections to annotations

* Adds newlines at the end of the file

* Adds horizontal pod autoscaler to cluster local gateway

* Cluster local gateway for Istio 1.1.6

* Tests for cluster local gateway istio 1.1.6

* Adds cluster-local-gateway to istio-1.1.6 kfdefs

* Deployment spec to apps/v1

* Adds horizontal pod autoscaler to cluster local gateway

Co-authored-by: Dan Sun <dsun20@bloomberg.net>
Co-authored-by: Krishna Durai <krishnadurai20@gmail.com>
@yuzisun yuzisun mentioned this pull request Apr 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishnadurai krishnadurai krishnadurai approved these changes

@animeshsingh animeshsingh Awaiting requested review from animeshsingh

Assignees

@krishnadurai krishnadurai

Labels
approved cla: yes lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues with KFServing as part of a Kubeflow install
6 participants
@yuzisun @animeshsingh @jlewi @k8s-ci-robot @krishnadurai @googlebot