Remove the E2E test to unblock presubmits #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @gabrielwen |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabrielwen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* The e2e test is failing because kfctl has moved from kubeflow/kubeflow to kubfelow/kfctl (kubeflow/kfctl#7) * The existing E2E test is an outdated copy of the old ksonnet workflow * To unblock presubmits we are just deleting this test * In a subsequent PR we will add back an E2E test but avoid duplicating the test and just check the test out from kubeflow/kubeflow or kubeflow/kfctl related: kubeflow#613
1 task
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The e2e test is failing because kfctl has moved from kubeflow/kubeflow
to kubfelow/kfctl (Make kubeflow/kfctl source of truth for kfctl development; turn down kfctl in kubeflow/kubeflow kfctl#7)
The existing E2E test is an outdated copy of the old ksonnet workflow
To unblock presubmits we are just deleting this test
In a subsequent PR we will add back an E2E test but avoid duplicating the
test and just check the test out from kubeflow/kubeflow or kubeflow/kfctl
related: #613
Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
Checklist:
cd manifests/testsmake generatemake testThis change is