add installation guidelines to issue template #2846

hansinikarunarathne · 2024-08-17T14:32:17Z

Pull Request Template for Kubeflow manifests Issues

✏️ A brief description of the changes

I installation guidelines to issue template

✅ Contributor checklist

Make sure you have tested with kustomize. See Installation Prerequisites
All the commits have been signed-off (To pass the DCO check)
Submit the Contributor License Agreements (To pass the cla/google check)

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

google-oss-prow · 2024-08-17T14:32:30Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kimwnasptd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

.github/ISSUE_TEMPLATE/issue-report.yml

juliusvonkohout · 2024-08-18T14:55:55Z

.github/ISSUE_TEMPLATE/issue-report.yml

+    options:
+    - master
+    - 1.9
+    - 1.8


Drop 1.8, we do not support it anymore.

no not fixed, you removed 1.9 instead of 1.8

Hey, what do I need to drop 1.8 or 1.9? In the above you have mentioned dropping 1.9

You are right, now it says correctly drop 1.8

So please drop 1.8 and keep 1.9

.github/ISSUE_TEMPLATE/issue-report.yml

juliusvonkohout · 2024-08-26T07:55:15Z

.github/ISSUE_TEMPLATE/issue-report.yml

-        1. Try this ...
-        2. Then do this ...
-    validations:
+    - label: Did you follow the installation guide https://github.com/kubeflow/manifests?tab=readme-ov-file ?


- label: Did you follow the [Kubeflow installation guide](https://github.com/kubeflow/manifests/blob/master/README.md) ?

juliusvonkohout · 2024-08-26T07:55:53Z

.github/ISSUE_TEMPLATE/issue-report.yml

+- type: markdown
+  attributes:
+    value: |
+      Follow the [Kubeflow Guidelines](https://github.com/kubeflow/manifests/blob/master/README.md) for installation.


Follow the [Kubeflow installation guideline](https://github.com/kubeflow/manifests/blob/master/README.md).

Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk>

* Added pipelines to PSS test and fixed typo Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com> * Added dynamic namespaces to PSS test Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com> --------- Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com> Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk>

* Training operator CICD improvements (kubeflow#2779) * Add the networkpolicies Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * rework the training operator tests Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * fix the comments Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * fix filename Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * try to fix the permissions Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * try to fix the permissions Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * change to the user namespace Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * update the image to rc.1 Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * fixes Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * fixes Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * fixes Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * fixes Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * fixes Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> --------- Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> * create seperate file for install_KinD_create_KinD_cluster_install_kustomize.sh to avoid code repitition Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> * make sh file executable Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> * remove reduntant codes Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> * combine kind, kuztomize and kind-cluster create sh files into one file Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> * fix issues with combined file Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> * fix configurations issues Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> * fix linting issues in workflow files Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> * fix trailing issues in workflow files Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> * fix trailing issues in workflow file bentoml Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> * made tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh executable and removed chmod command from the workflow files Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> * made modifications in workflow files Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> * deleted redundant files from tests folder Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> * Add kustomize installation file Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> * made install_kustomize.sh file executable Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> * made a fix Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> * fix issue with linting of YAML files (kubeflow#2825) * fix issue with linting of YAML files Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * delete a file to check the functionality Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * Add the after checking the functionality Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * Add folders to yaml linting Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * check linting issues Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * check linting issues Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * check linting changes Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * check linting functionality by chnaging different files Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * made some fixes in linting YAML file Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * made some fixes in linting YAML file Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * made some fixes in linting YAML file and check the functionality Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * made some fixes in linting YAML file and check the functionality Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * Add github, hack and tests folders also for linting Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * Check functionality by deleting sh from hack and yaml file common Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * Added deleted files Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> --------- Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> * Expose Ray and Seldon to example kustomization.yaml file (kubeflow#2834) * Expose Ray and Seldon to example kustomization.yaml file Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * Add internal documentations for ray and seldon Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> --------- Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> * Increase the time out of notebook and katib test Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> * increase the timout time Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> * increase timeout of the create pipeline Run from Kubeflow Notebook to 2400s Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> * Add code to calculate time taken to pull a docker image Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> * fix syntax error in yaml file Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> * increase pipeline time Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> * remove one step in action Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> * Added tests to tests/gh-actions to enable baseline and restricted PSS (kubeflow#2819) * Patched PSS labels to multi_tenancy Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com> * Added script in gh-actions to patch PSS/static/baseline/pacthes Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com> * Added PSS scripts for both baseline and restricted labels of static namespaces and renamed directories Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com> * Added tests to enable PSS in gh-actions Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com> * Added workflow test for PSS labels Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com> * Fixed indentation Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com> --------- Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com> Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> * add kind cluster step into pss test yaml file Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> * change time pot time Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> --------- Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk> Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com> Co-authored-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> Co-authored-by: biswajit-9776 <115724497+biswajit-9776@users.noreply.github.com> Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk>

* renable more parts of the dex test Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * fix dex-login-test (kubeflow#2830) * fix dex-login-test: - set executable permission for python script - set shebang line in python script Signed-off-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com> * Add all required componentes which have to be installed to test dex login Signed-off-by: Tom Zaspel <tom@zaspel.it> * Add kustomizeation file to deploy all required stuff to test dex login Signed-off-by: Tom Zaspel <tom@zaspel.it> * Add statuscode response in dex login Signed-off-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com> --------- Signed-off-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com> Signed-off-by: Tom Zaspel <tom@zaspel.it> --------- Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> Signed-off-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com> Signed-off-by: Tom Zaspel <tom@zaspel.it> Co-authored-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com> Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk>

* Update kubeflow/kubeflow manifests from v1.9.0 Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * update synchronization script Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> --------- Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk>

kubeflow#2843) Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk>

Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk>

google-oss-prow bot added the size/XS label Aug 17, 2024

google-oss-prow bot requested review from juliusvonkohout and kimwnasptd August 17, 2024 14:32

google-oss-prow bot added size/L and removed size/XS labels Aug 17, 2024

juliusvonkohout requested changes Aug 19, 2024

View reviewed changes

hansinikarunarathne requested a review from juliusvonkohout August 23, 2024 05:13

juliusvonkohout reviewed Aug 26, 2024

View reviewed changes

google-oss-prow bot added size/XL and removed size/L labels Aug 26, 2024

hansinikarunarathne and others added 10 commits August 26, 2024 18:46

add installation guidelines to issue template

9d0ae01

Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk>

fix trailing issues

b28f39d

Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk>

fixing indention errors

1dd0830

Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk>

fix issues with issue_report.yaml

c371844

Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk>

Change kind version and kubernetes version to support networkpolicies… (

e2a8c45

kubeflow#2843) Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk>

did requested chnages

0ee68ec

Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk>

hansinikarunarathne force-pushed the feature-add-installation-guidelines-to-README-file branch from c73cfdd to 0ee68ec Compare August 26, 2024 13:16

hansinikarunarathne closed this Aug 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add installation guidelines to issue template #2846

add installation guidelines to issue template #2846

hansinikarunarathne commented Aug 17, 2024

google-oss-prow bot commented Aug 17, 2024

juliusvonkohout Aug 18, 2024 •

edited

Loading

hansinikarunarathne Aug 23, 2024

juliusvonkohout Aug 26, 2024

hansinikarunarathne Aug 26, 2024

juliusvonkohout Aug 26, 2024 •

edited

Loading

juliusvonkohout Aug 26, 2024 •

edited

Loading

juliusvonkohout Aug 26, 2024 •

edited

Loading

juliusvonkohout Aug 26, 2024 •

edited

Loading

add installation guidelines to issue template #2846

add installation guidelines to issue template #2846

Conversation

hansinikarunarathne commented Aug 17, 2024

Pull Request Template for Kubeflow manifests Issues

✏️ A brief description of the changes

✅ Contributor checklist

google-oss-prow bot commented Aug 17, 2024

juliusvonkohout Aug 18, 2024 • edited Loading

Choose a reason for hiding this comment

hansinikarunarathne Aug 23, 2024

Choose a reason for hiding this comment

juliusvonkohout Aug 26, 2024

Choose a reason for hiding this comment

hansinikarunarathne Aug 26, 2024

Choose a reason for hiding this comment

juliusvonkohout Aug 26, 2024 • edited Loading

Choose a reason for hiding this comment

juliusvonkohout Aug 26, 2024 • edited Loading

Choose a reason for hiding this comment

juliusvonkohout Aug 26, 2024 • edited Loading

Choose a reason for hiding this comment

juliusvonkohout Aug 26, 2024 • edited Loading

Choose a reason for hiding this comment

juliusvonkohout Aug 18, 2024 •

edited

Loading

juliusvonkohout Aug 26, 2024 •

edited

Loading

juliusvonkohout Aug 26, 2024 •

edited

Loading

juliusvonkohout Aug 26, 2024 •

edited

Loading

juliusvonkohout Aug 26, 2024 •

edited

Loading