Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extract_images.sh #2658

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Update extract_images.sh #2658

merged 2 commits into from
Apr 3, 2024

Conversation

juliusvonkohout
Copy link
Member

@difince please check and /lgtm

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:

Checklist:

  • Unit tests pass:
    Make sure you have installed kustomize == 5.2.1+
    1. make generate-changed-only
    2. make test

@juliusvonkohout
Copy link
Member Author

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rimolive
Copy link
Member

Don't forget to sign-off your commit.

@difince please check and /lgtm

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout juliusvonkohout force-pushed the juliusvonkohout-patch-1 branch from 13fb5f9 to 5048e78 Compare April 3, 2024 12:25
@juliusvonkohout juliusvonkohout mentioned this pull request Apr 3, 2024
1 task
@rimolive
Copy link
Member

rimolive commented Apr 3, 2024

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Apr 3, 2024
@google-oss-prow google-oss-prow bot merged commit 2269c67 into master Apr 3, 2024
7 checks passed
@juliusvonkohout juliusvonkohout deleted the juliusvonkohout-patch-1 branch April 8, 2024 05:27
doncorsean pushed a commit to doncorsean/kubeflow-manifests that referenced this pull request Jul 18, 2024
* Update extract_images.sh

@difince please check and /lgtm

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Update kustomization.yaml

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

---------

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants