Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync metadata folder from master to v1-branch #1074

Closed
wants to merge 1 commit into from

Conversation

zhenghuiwang
Copy link
Contributor

@zhenghuiwang zhenghuiwang commented Apr 3, 2020

This PR fixes the issue of v1-branch that metadata-db deployments can't be connected from other pods.

The cause is that v1-branch misses some istio-sidecar annotations. This PR adds them back to v1-branch.

@kubeflow-bot
Copy link
Contributor

This change is Reviewable

@richardsliu
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhenghuiwang
Copy link
Contributor Author

/test kubeflow-manifests-presubmit

@zhenghuiwang
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@zhenghuiwang: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-manifests-presubmit bfc7216 link /test kubeflow-manifests-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhenghuiwang
Copy link
Contributor Author

@kunmingg the above tests for manifest v1.0-branch are broken due to KFAM. Do you know what changes from master need to be cherry picked?

/cc @kunmingg

@k8s-ci-robot k8s-ci-robot requested a review from kunmingg April 5, 2020 02:24
@jlewi
Copy link
Contributor

jlewi commented Apr 5, 2020

/hold

@jlewi
Copy link
Contributor

jlewi commented Apr 5, 2020

See: kubeflow/kfctl#296

I'm not sure this is the correct way to fix the issue. Per kubeflow/kfctl#296 the problem right now is that newer versions of kfctl are not backwards compatible with existing 1.0 configs because they turn on istio side car injection.

This change would be a forward fix that requires people to use newer versions of manifests with the newer versions of kfctl.

I think the ideal fix would be to figure out how to make kfctl backwards compatible; i.e. not turn on istio side car injection in the kubeflow namespace for 1.0 manifests.

@zhenghuiwang zhenghuiwang deleted the fix-v1 branch April 6, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants