Skip to content

Commit

Permalink
added support for registration flow env variable (#1335)
Browse files Browse the repository at this point in the history
adding expected test changes
  • Loading branch information
maganaluis authored Jul 7, 2020
1 parent bad1ffe commit 0186ae8
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 1 deletion.
2 changes: 2 additions & 0 deletions common/centraldashboard/base/deployment_patch.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,5 @@ spec:
value: $(userid-prefix)
- name: PROFILES_KFAM_SERVICE_HOST
value: profiles-kfam.kubeflow
- name: REGISTRATION_FLOW
value: $(registration-flow)
7 changes: 7 additions & 0 deletions common/centraldashboard/base/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,5 +53,12 @@ vars:
apiVersion: v1
kind: ConfigMap
name: parameters
- fieldref:
fieldPath: data.registration-flow
name: registration-flow
objref:
apiVersion: v1
kind: ConfigMap
name: parameters
configurations:
- params.yaml
3 changes: 2 additions & 1 deletion common/centraldashboard/base/params.env
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
clusterDomain=cluster.local
userid-header=
userid-prefix=
userid-prefix=
registration-flow=true
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ spec:
value: 'accounts.google.com:'
- name: PROFILES_KFAM_SERVICE_HOST
value: profiles-kfam.kubeflow
- name: REGISTRATION_FLOW
value: "true"
image: gcr.io/kubeflow-images-public/centraldashboard:vmaster-gf39279c0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
apiVersion: v1
data:
clusterDomain: cluster.local
registration-flow: "true"
userid-header: X-Goog-Authenticated-User-Email
userid-prefix: 'accounts.google.com:'
kind: ConfigMap
Expand Down

0 comments on commit 0186ae8

Please sign in to comment.