-
Notifications
You must be signed in to change notification settings - Fork 137
Conversation
Hi @xauthulei. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @jinchihe ,Could you review this |
/ok-to-test Thanks @xauthulei Could you actually delete the line
Related to #3605 |
b268a5f
to
6d80244
Compare
@jlewi , I have removed it, please review that again. Thanks for your efforts here. |
@jlewi , i found that we also need to remove
Am I right ? |
You are correct ; we need to remove all references to ks |
6d80244
to
4f1ddb0
Compare
@jlewi , I have removed that. please review that. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@xauthulei Can you cherry pick this onto kubeflow/kubeflow? We are still developing kfctl in kubeflow/kubeflow (see #7) Right now we periodically copy all the changes from kubeflow/kubeflow to kubeflow/kfctl. So your changes will get overwritten unless you commit this on kubeflow/kubeflow Sorry I missed this during my review; I didn't think to check what repo this was in. |
@jlewi, I will do it in kubeflow, Thanks again for your great efforts here. |
When execute the CMD:
kfctl generate all -V