This repository was archived by the owner on Aug 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
03c0b9a
to
75ea708
Compare
5257eff
to
f3fe51e
Compare
/assign @jlewi Jeremy This is ready to merge. I verified from the presubmit job that the build and kfctl subcommands are using kubeflow/kfctl
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kkasravi
pushed a commit
to kkasravi/kfctl
that referenced
this pull request
Sep 9, 2019
* prow fix to run in the right repo * point to kubeflow/kubeflow for config * add kubeflow/kubeflow as required repo * change to testing/e2e * add deploy_utils.py * relocating util scripts * leave srcDir pointing to kubeflow/kubeflow but change kubeflowPy * set kubeflowPy back go srcDir * expand PYTHONPATH * add semi-colon
swiftdiaries
pushed a commit
to swiftdiaries/kfctl
that referenced
this pull request
Sep 9, 2019
* prow fix to run in the right repo * point to kubeflow/kubeflow for config * add kubeflow/kubeflow as required repo * change to testing/e2e * add deploy_utils.py * relocating util scripts * leave srcDir pointing to kubeflow/kubeflow but change kubeflowPy * set kubeflowPy back go srcDir * expand PYTHONPATH * add semi-colon
kkasravi
pushed a commit
to kkasravi/kfctl
that referenced
this pull request
Sep 10, 2019
* prow fix to run in the right repo * point to kubeflow/kubeflow for config * add kubeflow/kubeflow as required repo * change to testing/e2e * add deploy_utils.py * relocating util scripts * leave srcDir pointing to kubeflow/kubeflow but change kubeflowPy * set kubeflowPy back go srcDir * expand PYTHONPATH * add semi-colon
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was executing in kubeflow/kubeflow
This change is