Skip to content
This repository was archived by the owner on Aug 17, 2023. It is now read-only.

prow fix to run in the right repo #17

Merged
merged 10 commits into from
Sep 9, 2019

Conversation

kkasravi
Copy link
Contributor

@kkasravi kkasravi commented Sep 4, 2019

this was executing in kubeflow/kubeflow


This change is Reviewable

@kkasravi
Copy link
Contributor Author

kkasravi commented Sep 6, 2019

/assign @jlewi

Jeremy

This is ready to merge. I verified from the presubmit job that the build and kfctl subcommands are using kubeflow/kfctl

  • build
util.py                     45 INFO     Running: make build-kfctl
cwd=/mnt/test-data-volume/kubeflow-kfctl-presubmit-kfctl-go-17-acce88f-7792-70d4/src/kubeflow/kfctl
  • kfctl init...
util.py                     45 INFO     Running: /mnt/test-data-volume/kubeflow-kfctl-presubmit-kfctl-go-17-acce88f-7792-70d4/src/kubeflow/kfctl/bin/kfctl init
/mnt/test-data-volume/kubeflow-kfctl-presubmit-kfctl-go-17-acce88f-7792-70d4/kfctl-70d4 -V --config=/mnt/test-data-volume/kubeflow-kfctl-presubmit-kfctl-go-17-a
cce88f-7792-70d4/tmp.yaml
  • kfctl apply...
util.py                     45 INFO     Running: /mnt/test-data-volume/kubeflow-kfctl-presubmit-kfctl-go-17-acce88f-7792-70d4/src/kubeflow/kfctl/bin/kfctl apply
 -V all
cwd=/mnt/test-data-volume/kubeflow-kfctl-presubmit-kfctl-go-17-acce88f-7792-70d4/kfctl-70d4
  • kfctl delete...
util.py                     45 INFO     Running: /mnt/test-data-volume/kubeflow-kfctl-presubmit-kfctl-go-17-acce88f-7792-70d4/src/kubeflow/kfctl/bin/kfctl delet
e all --delete_storage -V
cwd=/mnt/test-data-volume/kubeflow-kfctl-presubmit-kfctl-go-17-acce88f-7792-70d4/kfctl-70d4

@jlewi
Copy link
Contributor

jlewi commented Sep 9, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 45bf841 into kubeflow:master Sep 9, 2019
kkasravi pushed a commit to kkasravi/kfctl that referenced this pull request Sep 9, 2019
* prow fix to run in the right repo

* point to kubeflow/kubeflow for config

* add kubeflow/kubeflow as required repo

* change to testing/e2e

* add deploy_utils.py

* relocating util scripts

* leave srcDir pointing to kubeflow/kubeflow but change kubeflowPy

* set kubeflowPy back go srcDir

* expand PYTHONPATH

* add semi-colon
swiftdiaries pushed a commit to swiftdiaries/kfctl that referenced this pull request Sep 9, 2019
* prow fix to run in the right repo

* point to kubeflow/kubeflow for config

* add kubeflow/kubeflow as required repo

* change to testing/e2e

* add deploy_utils.py

* relocating util scripts

* leave srcDir pointing to kubeflow/kubeflow but change kubeflowPy

* set kubeflowPy back go srcDir

* expand PYTHONPATH

* add semi-colon
kkasravi pushed a commit to kkasravi/kfctl that referenced this pull request Sep 10, 2019
* prow fix to run in the right repo

* point to kubeflow/kubeflow for config

* add kubeflow/kubeflow as required repo

* change to testing/e2e

* add deploy_utils.py

* relocating util scripts

* leave srcDir pointing to kubeflow/kubeflow but change kubeflowPy

* set kubeflowPy back go srcDir

* expand PYTHONPATH

* add semi-colon
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants