Skip to content
This repository was archived by the owner on Aug 17, 2023. It is now read-only.

adds kfctl_k8s_istio config as a pre-submit test #11

Closed
wants to merge 2 commits into from

Conversation

swiftdiaries
Copy link
Member

@swiftdiaries swiftdiaries commented Aug 20, 2019

Adds the default config - kfctl_k8s_istio.yaml part of the pre-submit tests.
/cc @kkasravi


This change is Reviewable

@k8s-ci-robot k8s-ci-robot requested a review from kkasravi August 20, 2019 00:18
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kunmingg
You can assign the PR to them by writing /assign @kunmingg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@krishnadurai
Copy link
Contributor

/cc @krishnadurai

@kkasravi
Copy link
Contributor

kkasravi commented Sep 4, 2019

/retest

@jlewi
Copy link
Contributor

jlewi commented Sep 9, 2019

@swiftdiaries is this ready for review?

@swiftdiaries
Copy link
Member Author

I need to pull in changes. Let me do that now

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@k8s-ci-robot
Copy link
Contributor

@swiftdiaries: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
kubeflow-kfctl-presubmit 20e2c0e link /test kubeflow-kfctl-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@swiftdiaries swiftdiaries deleted the kfctl_k8s_test branch October 8, 2019 20:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants