Skip to content
This repository was archived by the owner on Aug 17, 2023. It is now read-only.

Move kfctl py code into kubeflow/kfctl #77

Closed
jlewi opened this issue Nov 6, 2019 · 5 comments
Closed

Move kfctl py code into kubeflow/kfctl #77

jlewi opened this issue Nov 6, 2019 · 5 comments

Comments

@jlewi
Copy link
Contributor

jlewi commented Nov 6, 2019

Related to #7 - move code for kfctl to kubeflow/kfctl

  • We need to move the python code related to testing kfctl into kubeflow/kfctl

  • We should create the directory py/kubeflow/kfctl and all code should live there

  • The kfctl related code in py/kubeflow/kubeflow/ci should move to [py/kubeflow/kfctl/ci]

  • Code in kubeflow/kubeflow testing/kfctl should move to [py/kubeflow/kfctl/ci] as well

  • The E2E test workflow should be updated to use this code.

  • If there is general code in testing that might be useful for other repos not just kubeflow/kfctl then we should consider moving it into the kubeflow/testing repo instead.

@jlewi
Copy link
Contributor Author

jlewi commented Nov 25, 2019

@richardsliu and @gabrielwen has the python code moved over?

@jlewi
Copy link
Contributor Author

jlewi commented Dec 9, 2019

@gabrielwen could you provide an update please? What work remains to get this done?

@gabrielwen
Copy link
Contributor

@jlewi I think I move all the code we need. just need second pair of eyes to make sure of that.

@jlewi
Copy link
Contributor Author

jlewi commented Dec 13, 2019

Thanks @gabrielwen .

I took a quick look.

It looks like we still have code here
https://github.com/kubeflow/kubeflow/tree/master/py/kubeflow/kubeflow/ci

That is also here:
https://github.com/kubeflow/kfctl/tree/master/py/kubeflow/kfctl/testing/ci

Lets delete the code in kubeflow/kubeflow and then we can close this

@jlewi
Copy link
Contributor Author

jlewi commented Jan 6, 2020

Fixed by #4577.

@jlewi jlewi closed this as completed Jan 6, 2020
crobby pushed a commit to crobby/kfctl that referenced this issue Dec 2, 2020
Signed-off-by: Landon LaSmith <LLaSmith@redhat.com>
vpavlin pushed a commit to vpavlin/kfctl that referenced this issue Jan 29, 2021
Signed-off-by: Landon LaSmith <LLaSmith@redhat.com>
crobby pushed a commit to crobby/kfctl that referenced this issue Feb 25, 2021
Signed-off-by: Landon LaSmith <LLaSmith@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants