Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

kfctl_test_delete is flaky and failures block upload of junit results #56

Open
jlewi opened this issue Oct 16, 2019 · 0 comments
Open

kfctl_test_delete is flaky and failures block upload of junit results #56

jlewi opened this issue Oct 16, 2019 · 0 comments
Labels
area/engprod area/kfctl priority/p0

Comments

@jlewi
Copy link
Contributor

jlewi commented Oct 16, 2019

Opening this issue because we are seeing flakes related to kfctl_delete_test.py failing

We are seeing timeouts
kubeflow/manifests#493 (comment)

And failures due to concurrent operations
kubeflow/kubeflow#4287

Even worse because of kubeflow/testing#257 if kfctl_delete_test fails we don't copy junit artifacts to GCS so we lose signal about passing tests.

As I stop gap I going to mark kfctl_test_delete as expected to fail. At least this way we won't block uploading junit artifacts.
@jlewi jlewi mentioned this issue Oct 16, 2019
Merged
1 task
@jlewi jlewi changed the title kfctl_test_delete is flaky kfctl_test_delete is flaky and failures block upload of junit results Oct 16, 2019
jlewi pushed a commit to jlewi/kubeflow that referenced this issue Oct 16, 2019
Mark kfctl_delete_test as expected to fail
b6589cf 
* See kubeflow/kfctl#56 the test is flaky
* More importantly if the test fails we end up blocking the uploading of
  junit files and we lose signal.
* So to prevent that we mark it as expected to fail. This way the step
  won't exit with non-zero exit code and the cleanup will continue.
@jlewi jlewi mentioned this issue Oct 16, 2019
Merged
k8s-ci-robot pushed a commit to kubeflow/kubeflow that referenced this issue Oct 16, 2019
@jlewi @k8s-ci-robot
Mark kfctl_delete_test as expected to fail (#4313)
ea02da2 
* See kubeflow/kfctl#56 the test is flaky
* More importantly if the test fails we end up blocking the uploading of
  junit files and we lose signal.
* So to prevent that we mark it as expected to fail. This way the step
  won't exit with non-zero exit code and the cleanup will continue.
@yanniszark yanniszark mentioned this issue Mar 29, 2020
Closed
saffaalvi pushed a commit to StatCan/kubeflow that referenced this issue Feb 11, 2021
@jlewi @k8s-ci-robot
Mark kfctl_delete_test as expected to fail (kubeflow#4313)
a0519b1 
* See kubeflow/kfctl#56 the test is flaky
* More importantly if the test fails we end up blocking the uploading of
  junit files and we lose signal.
* So to prevent that we mark it as expected to fail. This way the step
  won't exit with non-zero exit code and the cleanup will continue.
saffaalvi pushed a commit to StatCan/kubeflow that referenced this issue Feb 12, 2021
@jlewi @k8s-ci-robot
Mark kfctl_delete_test as expected to fail (kubeflow#4313)
eea2cae 
* See kubeflow/kfctl#56 the test is flaky
* More importantly if the test fails we end up blocking the uploading of
  junit files and we lose signal.
* So to prevent that we mark it as expected to fail. This way the step
  won't exit with non-zero exit code and the cleanup will continue.
crobby pushed a commit to crobby/kfctl that referenced this issue Jun 3, 2021
@anishasthana
Merge pull request kubeflow#56 from red-hat-data-services/update_master
82c3579 
Update manifests to 05/06 odh-manifests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area/engprod area/kfctl priority/p0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jlewi