Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade grpcio version to v1.64.1 #2483

Merged

Conversation

Electronic-Waste
Copy link
Member

@Electronic-Waste Electronic-Waste commented Jan 14, 2025

What this PR does / why we need it:

After #2344 got merged, our python grpc client is generated by buf.build/grpc/python:v1.64.1. However, our Python SDK still uses grpcio>=1.41.1, resulting in some errors like #2427.

This is due to the update of grpcio packge (the corresponding PR is grpc/grpc#36371). In v1.64.0, grpcio introduced a parameter __register_method to unary_unary, which would be called by grpc client in:

self.ReportObservationLog = channel.unary_unary(
'/api.v1.beta1.DBManager/ReportObservationLog',
request_serializer=api__pb2.ReportObservationLogRequest.SerializeToString,
response_deserializer=api__pb2.ReportObservationLogReply.FromString,
_registered_method=True)

And in tensorflow/tensorflow:2.13.0, the grpcio version is v1.56.0 while in tensorflow/tensorflow:2.17.0 the version is v1.64.1. So the error occurred in tensorflow/tensorflow:2.13.0, but not in tensorflow/tensorflow:2.17.0.

Given the fact that grpcio version is outdated, I upgrade the grpcio version to v1.64.1

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2427

Checklist:

  • Docs included if any changes are user facing

/cc @kubeflow/wg-automl-leads @helenxie-bit @tariq-hasan

Signed-off-by: Electronic-Waste <2690692950@qq.com>
@tenzen-y
Copy link
Member

/rerun-all

2 similar comments
@tenzen-y
Copy link
Member

/rerun-all

@Electronic-Waste
Copy link
Member Author

/rerun-all

@Electronic-Waste
Copy link
Member Author

@tenzen-y @andreyvelich The CI has succeeded. PTAL if you have time👀.

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 3b554aa into kubeflow:master Jan 14, 2025
63 checks passed
mahdikhashan pushed a commit to mahdikhashan/katib that referenced this pull request Jan 27, 2025
Signed-off-by: Electronic-Waste <2690692950@qq.com>
Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: unary_unary() got an unexpected keyword argument '_registered_method'
2 participants