Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Kubernetes to v1.31.3 #2478

Merged

Conversation

Electronic-Waste
Copy link
Member

@Electronic-Waste Electronic-Waste commented Jan 11, 2025

What this PR does / why we need it:

  • Kubernetes upgrade to v1.31.3
  • Minikube upgrade to v1.34.0 in CI
  • Remove deprecated grpc.Dial and replace it with grpc.NewClient

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2457

Checklist:

  • Docs included if any changes are user facing

/cc @kubeflow/wg-automl-leads @helenxie-bit @tariq-hasan

Signed-off-by: Electronic-Waste <2690692950@qq.com>
…elease-0.19.

Signed-off-by: Electronic-Waste <2690692950@qq.com>
Signed-off-by: Electronic-Waste <2690692950@qq.com>
Signed-off-by: Electronic-Waste <2690692950@qq.com>
@google-oss-prow google-oss-prow bot requested review from a team and helenxie-bit January 11, 2025 07:07
Copy link

@Electronic-Waste: GitHub didn't allow me to request PR reviews from the following users: tariq-hasan.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What this PR does / why we need it:

  • Kubernetes upgrade to v1.31.3
  • Minikube upgrade to v1.34.0 in CI

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2457

Checklist:

  • Docs included if any changes are user facing

/cc @kubeflow/wg-automl-leads @helenxie-bit @tariq-hasan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Electronic-Waste <2690692950@qq.com>
@Electronic-Waste
Copy link
Member Author

Error in CI: https://github.com/kubeflow/katib/actions/runs/12722327561/job/35466233718?pr=2478

Error: pkg/common/v1beta1/katib_manager_util.go:49:15: SA1019: grpc.Dial is deprecated: use NewClient instead.  Will be supported throughout 1.x. (staticcheck)
	conn, err := grpc.Dial(addr, grpc.WithTransportCredentials(insecure.NewCredentials()))
	             ^
Error: cmd/metricscollector/v1beta1/file-metricscollector/main.go:314:17: SA1019: grpc.Dial is deprecated: use NewClient instead.  Will be supported throughout 1.x. (staticcheck)
			conn, err := grpc.Dial(*earlyStopServiceAddr, grpc.WithTransportCredentials(insecure.NewCredentials()))
			             ^
Error: cmd/metricscollector/v1beta1/file-metricscollector/main.go:436:15: SA1019: grpc.Dial is deprecated: use NewClient instead.  Will be supported throughout 1.x. (staticcheck)
	conn, err := grpc.Dial(*dbManagerServiceAddr, grpc.WithTransportCredentials(insecure.NewCredentials()))
	             ^
make: *** [Makefile:38: lint] Error 1
Error: Process completed with exit code 2.

We also need to re-implement grpc-related logic.

Signed-off-by: Electronic-Waste <2690692950@qq.com>
@Electronic-Waste
Copy link
Member Author

This PR has been ready for review now!

PTAL if you have time👀 @kubeflow/wg-automl-leads @helenxie-bit @tariq-hasan

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this update @Electronic-Waste!
/lgtm
/assign @kubeflow/wg-training-leads

@Electronic-Waste
Copy link
Member Author

/assign @kubeflow/wg-automl-leads

k8s.io/api v0.31.3
k8s.io/apimachinery v0.31.3
k8s.io/client-go v0.31.3
k8s.io/code-generator v0.31.3
k8s.io/klog v1.0.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are going to update klog to v2 in PR: #2470

Signed-off-by: Electronic-Waste <2690692950@qq.com>
Signed-off-by: Electronic-Waste <2690692950@qq.com>
@Electronic-Waste
Copy link
Member Author

I've fixed the comments you raised. PTAL👀 if you are available. Thanks!

/cc @kubeflow/wg-automl-leads

@google-oss-prow google-oss-prow bot requested a review from a team January 14, 2025 06:35
@tenzen-y
Copy link
Member

/rerun-all

1 similar comment
@Electronic-Waste
Copy link
Member Author

/rerun-all

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit bf4a0b2 into kubeflow:master Jan 14, 2025
63 checks passed
mahdikhashan pushed a commit to mahdikhashan/katib that referenced this pull request Jan 27, 2025
* chore(ci): add k8s version 1.31.

Signed-off-by: Electronic-Waste <2690692950@qq.com>

* chore(Makefile): upgrade envtest version to 1.31 & setup-envtest to release-0.19.

Signed-off-by: Electronic-Waste <2690692950@qq.com>

* chore: update k8s related package in go.mod

Signed-off-by: Electronic-Waste <2690692950@qq.com>

* chore: make generate.

Signed-off-by: Electronic-Waste <2690692950@qq.com>

* fix(test): add SkipNameValidation option to test frame.

Signed-off-by: Electronic-Waste <2690692950@qq.com>

* refactor(grpc): remove deprecated grpc.Dial implementation.

Signed-off-by: Electronic-Waste <2690692950@qq.com>

* fix(dependency): remove dependency on k8s v1.28

Signed-off-by: Electronic-Waste <2690692950@qq.com>

* fix: add type assertion to ptr.To

Signed-off-by: Electronic-Waste <2690692950@qq.com>

---------

Signed-off-by: Electronic-Waste <2690692950@qq.com>
Signed-off-by: mahdikhashan <mahdikhashan1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Kubernetes v1.28 - v1.31
3 participants