-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSoC] Provide a PyTorch MNIST Example for Push-based Metrics Collection #2437
[GSoC] Provide a PyTorch MNIST Example for Push-based Metrics Collection #2437
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@Electronic-Waste Could we implement CI powered by papermill first in a separate PR? |
It seems that #2417 mentioned it and has already been taken by someone. I'll ask the assignee about the progess. And if he doesn't have time, I would be glad to take it :) Please let me know your thoughts. cc @tenzen-y @andreyvelich |
As Andrey mentioned in the issue, we are working on it at the traininig-operator, first. |
Yeah, I see! I'm looking forward to enhance my understanding of Training-Operator through this issue :) |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@Electronic-Waste: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Electronic-Waste: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove-lifecycle stale |
@tenzen-y @Electronic-Waste Should we move forward with this PR, since we need to release Katib 0.18, and we can implement E2Es for the Notebook in the followup PRs? |
@andreyvelich Yeah, I agree with you. Waiting for the e2e test may take a long time. We can release rc0 first:) |
@Electronic-Waste Please can you rebase this PR to fix E2Es, so we can merge it ? |
Signed-off-by: Electronic-Waste <2690692950@qq.com>
acc853b
to
8c7116e
Compare
@andreyvelich I've updated this branch by rebasing to the newest master branch. PTAL if you have time👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Electronic-Waste!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Provide a Pytorch MNIST example for push-based metrics collection.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Checklist: