Fix paths in prow config #1257
Merged
Fix paths in prow config #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made few changes in prow to not trigger v1alpha3 workflow when we make changes in v1beta1:
pkg/apis/controller/a*.go.pkg/apis/controller/*.gowas triggering workflow for any changes in.gofiles underpkg/apis/controllerdir.Here is an example: https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/kubeflow_katib/1140/kubeflow-katib-presubmit/1271359897765679104/.
Triggering workflow e2e-v1alpha3 because pkg/apis/controller/common/v1beta1/common_types.go in dir pkg/apis/controller/*.go is modified.pkg/apis/v1alpha3/*.examples/v1alpha3/*, I think we should trigger workflow if we make changes in Training containers examples.test/workflows/components/workflows-<version>.libsonnetwe can wait until Add exclude directories support to prow_config.yaml testing#585 will be done. For now we can keeptest/workflows/*/assign @johnugeorge @gaocegege