Enable Prettier code formatting for the Katib UI #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaocegege
reviewed
Mar 5, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
4 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
@gaocegege CI passed. |
|
/lgtm |
sperlingxx
pushed a commit
to sperlingxx/katib
that referenced
this pull request
Jul 9, 2020
* Enable Prettier in the Katib UI * Change travis * Change prettier-check in Makefile * Fix check format script * Fix README * Add missing points * Fix URL in README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added Prettier code formatter to the Katib UI and formatted all the frontend code.
I think, it will be better and easier for review if our frontend code will have the same style.
Also, I added lint check to the Travis CI.
And I added README for the Katib UI.
/assign @johnugeorge @gaocegege
/cc @richardsliu @hougangliu
This change is